WowAce

I dont use any actionbar addons other than DrDamage if you can even count that as one.

As an undead priest, when i mouse over Divine Hymn, this error msg pops up every time. Really annoying when im PvPing.

interface\addons\drdamage\caster.lua: 1787: attempt to index local 'tableSpell' (a nil value)

I need more information than this.

What race, class, level? What spell seems to be causing the issue?

I am a Dwarf warrior,when I learned Slam rank 7（http://www.wowhead.com/?spell=47474），it happens
DrDamage-1.6.0b\\Melee.lua:1413: attempt to concatenate field 'AP' (a nil value)\nDrDamage-1.6.0b\\DrDamage.lua:1221: in function \n(tail call): ?:\nInterface\\FrameXML\\ActionButton.lua:408: in function `ActionButton_SetTooltip':\n:\"*:OnEnter\":1: in function <[string \"*:OnEnter\"]:1>\n\n ---

sorry,would you please fix
DrDamage-1.6.0b\\Melee.lua:1413: attempt to concatenate field 'AP' (a nil value)\nDrDamage-1.6.0b\\DrDamage.lua:1221: in function <Interface\\AddOns\\DrDamage\\DrDamage.lua:1196>\n(tail call): ?:\nInterface\\FrameXML\\ActionButton.lua:408: in function `ActionButton_SetTooltip':\n<string>:\"*:OnEnter\":1: in function <[string \"*:OnEnter\"]:1>\n\n ---

one more issue... FFB spelldamage coeff is now incorrectly very high. I'm guessing this is a result of changing the school to 'frostfire' ... and drdamage doesnt know how to handle +dmg for the frostfire school?

after a little more digging... it seems that in caster.lua spell damage for FFb (caught me off-guard by the reference to spell ID) is not having the base spell damage being subtracted properly. It seems that GetSpellBonusDamage(1) is returning "0"

You are correct, FFB is a spell that benefits from fire and frost modifiers. I am unsure how resistance come into play, but i do know that immunity to frost or fire has no effect on FFB. Setting the school to frostfire and updating the talents worked great... and EP works correctly.

The one thing that didnt work is the crit chance.. I noticed that the caster.lua hack was pulling melee crit for baseCritChance, not spell crit... I fixed it by changing it to:

if DrD_MatchData(baseSpell.School, "Frostfire") then local baseCritTemp = GetSpellCritChance(1)

I've kept a separate secondary effect simply because Blizzard has done a wonderful job of making the tooltip ambiguous and confusing. I was originally led to believe that it would apply frost effects to the frost version of FFB and fire effects to the fire version, and whichever would do more damage to the target (after resistances and buffs/debuffs are taken into account) is the one that ended up occurring.

But now I'm of the impression that all frost and fire effects are applied to BOTH versions of FFB, and that the only deciding factor is the target's fire/frost resistances? In which case, I guess there really is absolutely no point in keeping separate fire and frost versions of FFB... Am I correct in this?

I've done the following:

• Commented out the secondary effect of FFB.
• Set the "School" of FFB to "Frostfire" so it will trigger the calculation I added in Caster.lua for frostfire crits.
  • This will have the unfortunate effect of excluding things such as potions and other (non-mage originating) buffs/debuffs such as the ones in Aura.lua, which boost fire or frost damage. I will have to go through this later and make sure that these are taken into account properly.
• Changed the EP talent similar to your suggestion, the first effect applies to Frost, Fire and Frostfire, and the second effect applies to Frostfire Bolt. In theory, this should result in FFB gaining 1-3% hit from being in the Frostfire school, and another 1-3% hit for being the spell "Frostfire Bolt". DrDamage has a habit of not enjoying my hacks, so let me know if this last one doesn't take effect as planned.

Thanks for the help zoeckler, let me know how my changes go!

Latest beta seems to have improved the calculation of crits on Frostfire Bolt. However, it also seems to be counting spell power twice. ie I have 1007 spell power, but Frostfire Bolt displays +2014 spell power.

The major theorycrafters agree that FFB gets double benefits from EP... from my last post: ...since it has been shown that frostfire bolt gets double benefit from the +hit talent, i fixed it by doing this:

[GetSpellInfo(29438)] = { [1] = { Effect = 1, Spells = { "Frost", "Fire" }, ModType = "hitPerc" }, [2] = { Effect = 1, Spells = "Frostfire Bolt", ModType = "hitPerc" }, },

ALSO, FFB is showing base crit chance, not the fireCrit+frostCrit-baseCrit that you set up in the caster.lua. Once you get that working... it would be correct. - i want to mention, however, that no talents right now increase frost crit chance above baseCrit... so this function is technically not needed at this time.

oh, i found one of the issues... in the spell detail area, you swapped the frostfire order so that it is classified as "Frost" first, then "Fire"... it seems that the [secondary] is not doing anything functional (which I already knew)... so as of the latest build is is only classifying FFB as "frost", and therefore showing only frostCrit in the tooltip (which is the same as baseCrit).

i fixed this locally by removing the [secondary] from FFB and putting in in the "fire" school. The modifications to the frost talents themselves should take care of the rest.

The shadow priest talent modifiers are still not quite right as far as I can tell from the code.
Shadow Form: The 15% bonus is a global 1.15 multiplier to the overall damage. The bonus from crit is also multiplicative, not additive.
Twin Disciplines: This talent also applies to Mind Flay. Not sure why, but it does.
The boni from Improved Shadow Word: Pain, Twin Disciplines, and Darkness are added up before applied multiplicatively. For Shadow Word: Pain, the computation would look like this: 6% from Imp SWP, 5% from Twin Disciplines, and 10% from Darkness add up to a 6%+5%+10%=21% bonus. The overall damage of SWP is multiplied by 1.21.
Glyph of Shadow Word: Pain, http://www.wowhead.com/?item=42415, I couldn't find it in the code. The bonus stacks multiplicatively with Twisted Faith. A fully talented TF and the Glyph yield a 10%+10%=20% bonus, so the overall damage of Mind Flay is multiplied by 1.2.

Thanks again, Tifi.

I'll get this all fixed up soon.

Regarding glyphs: There's currently no support for glyphs in DrDamage at all. Once i squash most of the basic class issues, it's next on my list of things to do.

Thank you so much for working on the death knight class.

kouik,

Repository access is not under my control as I am not project leader. Please feel free to continue posting tickets that's what they're there for after all. =)

Ekovah,

Are you sure FFB gets twice the effect of Elemental Precision? I'll try and verify this independently, sounds a little fishy but possible.

As for crit damage, I'll look into that. I'm not sure why max would be correct but min would not. They should both (in theory) be off by the same margin.

I think it was 1.6.0b-5. I don't really know where to grab the alphas.

Hey, nvm, found em. Installed r707, working now :) Thanks!

I'm curious: Is this with 1.6.0b-5, or with the latest alpha version?

Got a bug:
Interface\AddOns\DrDamage\[Melee.lua:1009]: attempt to perform arithmetic on local 'minDam_O' (a nil value)
Using Dominos.
Level 80 Undead Rogue.

I looked briefly at one of your earlier builds a couple weeks ago when I spoke to you on the wowace comments page, but not since then. As I mentioned then, I had planned to write it from scratch since it would involve significant additions to the melee.lua, caster.lua and/or drdamage.lua files.

It's not really any surprise that parts of it might seem similar given the generalized structure of the class files. Each of the classes look similar to one another even. I merely copied Gagorian's original layout template as I applied my own work.

As for your build having worked better than mine, that's fair. Keep in mind however that mine is the first alpha release, I still have work to do yet - I certainly don't claim perfect implementation at this point. We crawl before we walk. =)