GnomeWorks TradeSkill Frame

Table of Contents

This project is abandoned and its default file will likely not work with the most recent version of World of Warcraft. Whether this project is out of date or its author has marked it as abandoned, this project is no longer maintained.

GnomeWorks TradeSkill Frame -

a complete replacement for the blizzard trade skill frame.

early alpha just to test some things out.

Comments

Air10000
- Join Date: 3/5/2007
- Posts: 99
- Member Details
#1799 Air10000

View User Profile

Send Message

Posted Sep 11, 2012
@WildCard_25

do you have any plans to tinker with LSW as well?

Rollback Post to Revision RollBack
WildCard_25
- Location: Brisbane
- Join Date: 12/2/2010
- Posts: 22
- Member Details
#1798 WildCard_25

View User Profile

Send Message

Posted Sep 11, 2012
I'd go for r186 ;-)

I blame my guild's raid times for not testing before I commited, but I decided to push them to the repository anyway (before Craig had a chance to add another 10 patches :-D )

(no I'm not a lilsparky alt, just another programmer that likes to tinker in his spare time)

Last edited by WildCard_25: Sep 11, 2012

Rollback Post to Revision RollBack
craigcurse
- Join Date: 6/25/2009
- Posts: 11
- Member Details
#1797 craigcurse

View User Profile

Send Message

Posted Sep 11, 2012
@Lesyde @Anteract

It looks like r182 has all my changes folded in with some minor formatting changes, and a couple typos. The following should fix things until wildcard_25 (is that a lilsparky alt?) gets the fixes into the release:

LinkDecode.lua line 201, remove the second closing )
SkillList.lua line 786, change numTradeSkills to numSkills

There's also a loop invariant optimization at SkillList.lua line 1255 which he seems to have reverted out from my patches; not sure why on that one.

There's a couple other fixes/enhancements that were included in r182 (actually changes r169-r172), so with the two fixes above, r182 is the one to get if you're comfortable editing those two files as described. If you're not comfortable, then I'd suggest grabbing the one from the ticket, or waiting for r183 :)
Rollback Post to Revision RollBack
OttoDeFe
Curse Premium
- Location: Seattle
- Join Date: 9/26/2008
- Posts: 11
- Member Details
#1796 OttoDeFe

View User Profile

Send Message

Posted Sep 10, 2012
Actually that's an easy fix, too... get rid of the "Trade" in "numTradeSkills".

Rollback Post to Revision RollBack
_ForgeUser8998507
- Join Date: 6/7/2012
- Posts: 0
- Member Details
#1795 _ForgeUser8998507

View User Profile

Send Message

Posted Sep 10, 2012
Still says out of date, even though I updated it to the latest and restarted the wow client.

Rollback Post to Revision RollBack

OttoDeFe

Curse Premium

Location: Seattle
Join Date: 9/26/2008
Posts: 11
Member Details

#1794 Posted Sep 10, 2012

That's a simple typo - remove the extra ")" on that line.

Unfortunately, that reveals this error:

["message"] = "GnomeWorks-r182\\SkillList.lua:786: \"for\" limit must be a number",
			["time"] = "2012/09/10 13:46:35",
			["stack"] = "GnomeWorks-r182\\SkillList.lua:786: in function \"ScanTrade\"\nGnomeWorks-r182\\MainWindow.lua:1581: in function <GnomeWorks\\MainWindow.lua:1577>\n(tail call): ?\n<in C code>\n<string>:\"safecall Dispatcher[2]\":9: in function <string>:\"safecall Dispatcher[2]\":5\n(tail call): ?\nAce3-r1064\\AceTimer-3.0\\AceTimer-3.0-6.lua:164: in function <Ace3\\AceTimer-3.0\\AceTimer-3.0.lua:138>",
			["session"] = 8639,
			["counter"] = 1,

mishikal1
- Join Date: 10/31/2008
- Posts: 97
- Member Details
#1793 mishikal1

View User Profile

Send Message

Posted Sep 10, 2012
182 gives: Date: 2012-09-10 17:39:39 ID: 1 Error occured in: Global Count: 1 Message: ..\AddOns\GnomeWorks\LinkDecode.lua line 201: unexpected symbol near ')'

Rollback Post to Revision RollBack
athgar
- Join Date: 3/5/2007
- Posts: 7
- Member Details
#1792 athgar

View User Profile

Send Message

Posted Sep 10, 2012
@Anteract

That's my experience as well.

Rollback Post to Revision RollBack
anteract
- Location: California
- Join Date: 10/7/2006
- Posts: 3
- Member Details
#1791 anteract

View User Profile

Send Message

Posted Sep 10, 2012
@Lesyde

My experience, the one from the ticket works. The r182, not so much.

Rollback Post to Revision RollBack
Forge_User_33720939
- Join Date: 6/28/2019
- Posts: 0
- Member Details
#1789 Forge_User_33720939

View User Profile

Send Message

Posted Sep 10, 2012
A new version came over the curse client today.

Updated my addon, but it's still just broken as all hell.

Got a few different errors, but the one i saved was:

Date: 2012-09-10 13:57:18
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\GnomeWorks\LinkDecode.lua line 201:
unexpected symbol near ')'
Debug:

Locals:

AddOns:
MoncaiCompare, v1.5.4
Swatter, v4.0.2 (<%codename%>)
Altoholic, v5.0.001c
Archy, v1.8.29
AtlasLootLoader, vv7.00.01
AucAdvanced, v5.14.5335 (KowariOnCrutches)
AucFilterBasic, v5.14.5335 (KowariOnCrutches)
AucFilterOutlier, v5.14.5335.5335(5.14/embedded)
AucMatchUndercut, v5.14.5335.5225(5.14/embedded)
AucStatHistogram, v5.14.5335 (KowariOnCrutches)
AucStatiLevel, v5.14.5335 (KowariOnCrutches)
AucStatPurchased, v5.14.5335 (KowariOnCrutches)
AucStatSales, v5.14.5335.5335(5.14/embedded)
AucStatSimple, v5.14.5335 (KowariOnCrutches)
AucStatStdDev, v5.14.5335 (KowariOnCrutches)
AucStatWOWEcon, v5.14.5335.5335(5.14/embedded)
AucUtilAHWindowControl, v5.14.5335.5133(5.14/embedded)
AucUtilAppraiser, v5.14.5335.5335(5.14/embedded)
AucUtilAskPrice, v5.14.5335.5160(5.14/embedded)
AucUtilAutoMagic, v5.14.5335.5335(5.14/embedded)
AucUtilCompactUI, v5.14.5335.5335(5.14/embedded)
AucUtilEasyBuyout, v5.14.5335.5238(5.14/embedded)
AucUtilFixAH, v5.14.5335 (KowariOnCrutches)
AucUtilItemSuggest, v5.14.5335.5335(5.14/embedded)
AucUtilPriceLevel, v5.14.5335.5237(5.14/embedded)
AucUtilScanButton, v5.14.5335.5335(5.14/embedded)
AucUtilScanFinish, v5.14.5335.5153(5.14/embedded)
AucUtilScanProgress, v5.14.5335.4979(5.14/embedded)
AucUtilScanStart, v5.14.5335.5153(5.14/embedded)
AucUtilSearchUI, v5.14.5335.5335(5.14/embedded)
AucUtilSimpleAuction, v5.14.5335.5208(5.14/embedded)
AucUtilVendMarkup, v5.14.5335.4828(5.14/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BagSort, v5.0.4
Bartender4, v4.5.3
BeanCounter, v5.14.5335 (KowariOnCrutches)
Castbars, v
CombustionHelper, v3.3
Configator, v5.1.DEV.335(/embedded)
DataStore, v5.0.001
DataStoreAchievements, v5.0.001
DataStoreAgenda, v5.0.001
DataStoreAuctions, v5.0.001
DataStoreCharacters, v5.0.001
DataStoreContainers, v5.0.001
DataStoreCrafts, v5.0.001
DataStoreCurrencies, v5.0.001
DataStoreInventory, v5.0.001
DataStoreMails, v5.0.001
DataStorePets, v5.0.001
DataStoreQuests, v5.0.001
DataStoreReputations, v5.0.001
DataStoreSpells, v5.0.001
DataStoreStats, v5.0.001
DataStoreTalents, v5.0.001
DBMCore, v
DebugLib, v5.1.DEV.312(/embedded)
ElkBuffBars, v2.3.2-169
EnchantrixBarker, v5.14.5335 (KowariOnCrutches)
Gatherer, v4.0.2
GnomeWorks, v182
LibExtraTip, v5.12.DEV.324(/embedded)
Stubby, v5.14.5335 (KowariOnCrutches)
TipHelper, v5.12.DEV.315(/embedded)
BlizRuntimeLib_enUS v5.0.4.50001 <us>
(ck=9aa)

Rollback Post to Revision RollBack
lesyde
Curse Premium
- Join Date: 4/23/2005
- Posts: 4
- Member Details
#1788 lesyde

View User Profile

Send Message

Posted Sep 10, 2012
Which version is the last one ? r182 or the one from the ticket?

Rollback Post to Revision RollBack
Revvek
- Join Date: 12/13/2006
- Posts: 13
- Member Details
#1787 Revvek

View User Profile

Send Message

Posted Sep 9, 2012
@hughescr

Thanks!

Rollback Post to Revision RollBack
craigcurse
- Join Date: 6/25/2009
- Posts: 11
- Member Details
#1786 craigcurse

View User Profile

Send Message

Posted Sep 9, 2012
For those not following on WoWAce, I've posted new updates which improve performance and fix a couple more bugs. You can get the updated download and/or patches from this ticket:

http://www.wowace.com/addons/gnomeworks/tickets/424-updated-mop-updates-full-addon-attached/

Rollback Post to Revision RollBack
craigcurse
- Join Date: 6/25/2009
- Posts: 11
- Member Details
#1785 craigcurse

View User Profile

Send Message

Posted Sep 9, 2012
@pfenrir

Yeah, it was something I did, but I actually did it slightly wrong and broke some stuff. I've got new updates now which fix the problems, and improve performance further, especially when crafting more than one item (using either queue or craft/craft all). The download and patches can be found on this ticket:

http://www.wowace.com/addons/gnomeworks/tickets/424-updated-mop-updates-full-addon-attached/

Rollback Post to Revision RollBack
alisonnic
- Join Date: 5/26/2010
- Posts: 14
- Member Details
#1784 alisonnic

View User Profile

Send Message

Posted Sep 6, 2012
I'd love to try your update for KTQ, Drashnar.

I have been testing the existing KTQ and Lil'Sparky's Workshop with craighughes' patched version of Gnomeworks. For the most part, the combination seems to work as before, except that after I've opened GW with KTQ and LSW enabled, when I log off, the WoW client almost always crashes to desktop, with popups asking me what I was doing and to send the debug data to the developers. Occasionally there are other symptoms, such as partial failure/long delays in loading parts of the UI (maps, bag & profession displays, etc.), sometimes followed by a crash.

Disabling KTQ doesn't fix the problem, so it appears that the issue is in LSW. Perhaps an array pointer is getting set out of bounds somewhere in LSW, and the WoW client isn't catching it. (I'm running the 64 bit client on Windows 7 Home Premium.)

Aside from the CTD's, one thing that doesn't seem to work is the feature that allows you to select an alt and view their professions and recipes. This doesn't work for me regardless of whether KTQ and LSW are enabled or not. Selecting All Recipes doesn't work either - but selecting a profession under my guild does work.

For now I guess my workaround will be to disable KTQ and LSW except when I absolutely need them. Maybe I'll try enabling/disabling them without logging out, using Addon Control Panel.

pfenrir, thanks for the suggestion about TradeSkillMaster. I did try it about a year ago but found it to be very cumbersome and bloated, with a clumsy UI and extremely arcane crafting parameter structures. It was quite awkward to set it up to automatically craft a specified number of a given item, with automatic reference to how many were already in the bags of my various alts or the AH.

I found the GW/LSW/KTQ suite, along with a few macros, to be much more elegant and far more easily maintained. GW is also much easier to use while leveling a profession, IMHO.

However, if we can't fix LSW and KTQ, I plan to try TSM again at some point. Maybe it has improved in the year since I tried it last.

Last edited by alisonnic: Sep 6, 2012

Rollback Post to Revision RollBack
_ForgeUser9568987
- Join Date: 7/1/2019
- Posts: 0
- Member Details
#1783 _ForgeUser9568987

View User Profile

Send Message

Posted Sep 5, 2012
This has been picked up and was updated in the last couple of days over on WowAce.

Rollback Post to Revision RollBack
_ForgeUser5875211
- Join Date: 10/18/2010
- Posts: 21
- Member Details
#1782 _ForgeUser5875211

View User Profile

Send Message

Posted Sep 4, 2012
I did a self update for KTQ when Cata hit that worked. I haven't been able to check it with the MoP patch yet, but once I see if I can work it out I'll email the files to any that want them.

Rollback Post to Revision RollBack
_ForgeUser921232
- Join Date: 7/7/2008
- Posts: 3
- Member Details
#1778 _ForgeUser921232

View User Profile

Send Message

Posted Sep 3, 2012
I'd also like to add my thanks to Craig for this back up and running and I really hope that a a "development team" can get ahold of lilsparky to make this official! This is by far the best tradeskill addon our there.

I would also like to note that somewhere in this process the massive lag that I used to get whenever I was crafting Glyphs and Gems has gone away. I don't know if that was something Craig did in his fixes or if there was a change somewhere else that got it, but it has cleared up at least for me. There is still a very minor delay, but I'm not seeing a framerate drop anymore let alone going down to 2-3 fps like it used to.

@alisonnic I haven't used KTQ in quite some time so I don't how well it is behaving these days, but you might want to give TradeskillMaster a shot. Takes a little time to get set up but once I got it set up it has made my life significantly easier with both creating and posting items. It also tracks inventory across all your toons, guild banks etc so you don't need an extra addon for that if you don't want "extra" addons just for inventory tracking.

Rollback Post to Revision RollBack
alisonnic
- Join Date: 5/26/2010
- Posts: 14
- Member Details
#1777 alisonnic

View User Profile

Send Message

Posted Sep 3, 2012
A thousand thank yous, Craig! I downloaded your complete working version and tested it on quite a few toons. It works! (More details on your patch page at http://www.wowace.com/addons/gnomeworks/tickets/422-fixes-to-get-inscription-working-in-mop/.)

I am delighted to have this indispensable addon working again. Fantastic job, Craig!

I very much hope we can get a team together to continue developing and refining this addon and its associated addons, LilSparky's Workshop and KevTool Queue. There are some glitches that need to be ironed out, but I've been using this combination every day for over a year for leveling professions and for crafting items to sell on the AH, and I don't know how I'd do this without them. Both processes would certainly be far less efficient - and less fun.

Bravo! I am forever in your debt, Craig!

Last edited by alisonnic: Sep 3, 2012

Rollback Post to Revision RollBack
_ForgeUser6661971
- Join Date: 4/16/2011
- Posts: 2
- Member Details
#1774 _ForgeUser6661971

View User Profile

Send Message

Posted Sep 2, 2012
Hey since you guys are taking over and upgrading this most awesome program, could add a lock size button please? Anytime you click anywhere in the brown parts of the frame it thinks you are trying to resize and adjusts it a little bit. This has always been annoying. Keep up the good work and thanks for taking over! No other crafting addon works as well as this one IMHO

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.