WowAce

Great Work craighughes!

I did notice an additional error: Date: 2012-09-02 05:59:32 ID: 10 Error occured in: Global Count: 8 Message: ..\AddOns\GnomeWorks\FrameHooks\Mail.lua line 64: bad argument #1 to 'next' (table expected, got nil) Debug: (tail call): ? [C]: next() GnomeWorks\FrameHooks\Mail.lua:64: GnomeWorks\FrameHooks\Mail.lua:55 (tail call): ? [C]: ? [string "safecall Dispatcher[2]"]:9: [string "safecall Dispatcher[2]"]:5 (tail call): ? ...rface\AddOns\Alts\Libs\AceTimer-3.0\AceTimer-3.0.lua:164: ...rface\AddOns\Alts\Libs\AceTimer-3.0\AceTimer-3.0.lua:138 Locals: None AddOns: Swatter, v5.15.5338 (LikeableLyrebird) NPCScan, v5.0.0.1 NPCScanOverlay, v5.0.0.1 ACP, v3.4 Alts, v0.7 AucAdvanced, v5.15.5338 (LikeableLyrebird) AucFilterBasic, v5.15.5338 (LikeableLyrebird) AucFilterOutlier, v5.15.5338.5323(/embedded) AucMatchUndercut, v5.15.5338.5225(/embedded) AucScanData, v5.15.5338 (LikeableLyrebird) AucStatHistogram, v5.15.5338 (LikeableLyrebird) AucStatiLevel, v5.15.5338 (LikeableLyrebird) AucStatPurchased, v5.15.5338 (LikeableLyrebird) AucStatSales, v5.15.5338.5305(/embedded) AucStatSimple, v5.15.5338 (LikeableLyrebird) AucStatStdDev, v5.15.5338 (LikeableLyrebird) AucStatWOWEcon, v5.15.5338.5323(/embedded) AucUtilAHWindowControl, v5.15.5338.5133(/embedded) AucUtilAppraiser, v5.15.5338.5336(/embedded) AucUtilAskPrice, v5.15.5338.5160(/embedded) AucUtilAutoMagic, v5.15.5338.5293(/embedded) AucUtilCompactUI, v5.15.5338.5336(/embedded) AucUtilEasyBuyout, v5.15.5338.5238(/embedded) AucUtilFixAH, v5.15.5338 (LikeableLyrebird) AucUtilItemSuggest, v5.15.5338.5314(/embedded) AucUtilPriceLevel, v5.15.5338.5237(/embedded) AucUtilScanButton, v5.15.5338.5320(/embedded) AucUtilScanFinish, v5.15.5338.5153(/embedded) AucUtilScanProgress, v5.15.5338.4979(/embedded) AucUtilScanStart, v5.15.5338.5153(/embedded) AucUtilSearchUI, v5.15.5338.5331(/embedded) AucUtilSimpleAuction, v5.15.5338.5208(/embedded) AucUtilVendMarkup, v5.15.5338.4828(/embedded) AuctionLite, v1.8.5 Babylonian, v5.1.DEV.312(/embedded) BadBoy, v10.016 BasicChatMods, v6.77 BeanCounter, v5.15.5338 (LikeableLyrebird) BlizzMove, vv1.2.5 ButtonFacade, v5.0.387 Configator, v5.1.DEV.330(/embedded) DailyQuestHelper, vv1.4 DebugLib, v5.1.DEV.312(/embedded) DuelResponse, v2.9.4 EquipCompare, v2.18 ExtVendor, v1.4.7 Factionizer, v4.3.0 FarmIt2, v FlightMap, v5.0.3 ForteCasting, v ForteClass, v ForteCooldown, v ForteCore, v1.980.3 ForteTalent, v ForteTimer, v GFWFactionFriend, v5.0 GFWXPVisualizer, v5.0 GnomeWorks, v@project-revision@ GTFO, v4.14 Informant, v5.15.5338 (LikeableLyrebird) iTip, v LibExtraTip, v5.12.DEV.324(/embedded) LightHeaded, v344 Mapster, v1.5.0 Masque, v5.0.387 MinimapButtonFrame, v3.1.9 MinimapButtonFrameSkinPack, v3.0.1 MobInfo2, v5.0.4.0 panda 1 NazScrooge, vv1.98 OmniCC, v5.0.1 Outfitter, v5.5.2 Pawn, v1.6.2 Postal, v3.5.0 QuestCompletist, v99.7 QuestGuru, v2.2.10-50001 QuestGuruTracker, v1.5.13-50001 Skada, v1.4-3 SkadaCC, v1.0 SkadaDamage, v1.0 SkadaDamageTaken, v1.0 SkadaDeaths, v1.0 SkadaDebuffs, v1.0 SkadaDispels, v1.0 SkadaEnemies, v1.0 SkadaHealing, v1.0 SkadaPower, v1.0 SkadaThreat, v1.0 SkillLevel, v1 Skinner, vb4.15595.11 SlideBar, v5.15.5338 (LikeableLyrebird) Stubby, v5.15.5338 (LikeableLyrebird) SuperLoot, v2.0 TBag, v TipHelper, v5.12.DEV.315(/embedded) TipTac, v12.09.01 TipTacItemRef, v12.08.30 TipTacTalents, v12.09.01 Titan, v5.1.1.50001 - Revision 519 TitanGold, v5.1.1.50001 TitanItemDed, v5.0.0.1 TitanLocation, v5.1.1.50001 TitanLootType, v5.1.1.50001 TitanRepair, v5.1.1.50001 TitanReputation, v3.7.6 TitanXP, v5.1.1.50001 TomTom, vv50001-1.0.2 tullaRange, v5.0.0 ZoneLevelInfo, v1.5.0 BlizRuntimeLib_enUS v5.0.4.50001 <us> (ck=ce4)

Thanks to everyone on keeping this alive!

Ok, I fixed it.  Now seems to work well with all professions on MoP 5.0.4, including inscription.

I've uploaded both the working version of the addon as well as the patches against r168 to produce said working version on the following ticket:

http://www.wowace.com/addons/gnomeworks/tickets/422-fixes-to-get-inscription-working-in-mop/

Ok, I've found what the problem with inscription is.  Inscription filtering has "slots" -- that is which inventory slot the crafted item goes into, and now it has "sub-slots", which are "BoE", "BoP", etc.  The Blizzard TradeSkill UI uses the GetTradeSkillSubCategories() and friends to deal with these; GnomeWorks is not expecting these sub-categories and is blowing up because of them.

Now that I know what the problem is, I just need to write the code to fix it.  First version fix will probably be a hack-job which just ignores the sub-category issue and puts all items in the sub-category just right into the parent category instead.

Quick comment.  People seem to be passing the same args to SetTradeSkillCategoryFilter as for SetTradeSkillSubClassFilter but that is incorrect.  None of the API sites have docs yet for the new function, but Blizzard's own UI does this:

-                SetTradeSkillSubClassFilter(TradeSkillFrame.filterTbl.subClassValue 1, 1);    
+                SetTradeSkillCategoryFilter(TradeSkillFrame.filterTbl.subClassValue 0);

So do not pass 1,1 use 0 instead.

I put a full patch here:

http://www.wowace.com/addons/gnomeworks/tickets/421-fixes-for-mop-5-0-4/

This still has the hang-for-inscription problem though.  I'll try and track that down next.

@Jaxomuk

Hope you can takeover LilSparky's Workshop as well since they go toghether if Sparky doesnt replay or come back

Further update: I disabled lil sparky's workshop, and I still have the same issue. Task Manager shows Wow taking up 100% of 1 CPU on my system when gnomeworks is opened up. Frame rate drops from 180-200 fps to 3-5 fps. Disabling gnomeworks makes the problem go away (trade skill window works fine)

As an addition to the community testing that seems to be going on (and thank you for the fixes posted and the work going into it!):

I made the changes suggested by athgar on the 29th, and clarified by alisonnic as far as which files and capitalization. My tradeskill window actually shows up now (nothing was happening before when I tried to open them), but instead of sorting my recipes by category, all recipes are listed under every category, giving me multiples of everything. That could be a cause for some of the slow-down some of us are experiencing.

When someone takes over management of this project, I would like to volunteer to help on this project. My Lua knowledge isn't extensive, but I'm a professional software engineer and I have very good troubleshooting skills.

Here's an item of interest that I hope has some relevance. I turned off Gnomeworks, but left Lil Sparky's Workshop running. LSW goes ahead and changes fonts in the Blizzard Tradeskill UI and adds the cost and auction values with no problem. This mod has a lot of interdependency so I'm hoping to just narrow things down a bit.

The last code I ever wrote was diagnostics for TI-810 printers, but I'm happy to squint at the screen if it helps someone sort this out.

@Jaxomuk:

The files are on their way to you right now. Thanks again!

Yes, getting it to work in alpha mode would be great. And if necessary - if Sparky doesn't come back - I'm sure we can find a way to distribute it, assuming we get it fixed before the 90 day wait is over.

Edit: I am not using PlayerScore. Haven't had it installed in some time. But I'm having the problem with the WoW client freezing when I open GnomeWorks, and then disconnecting. I do have a number of other addons installed, however.

Also, I am running the 64-bit WoW client on Windows 7 Home Premium, and connecting to US servers.

@athgar

Mine was with enchanting.

I'm seeing the same freezing issue, but only on inscription.

I see the hang on opening as well once the fix is in place. It eventually resumes after several seconds, and then will periodically hang while open for a few seconds at a time. As soon as I close gnomeworks, the issue goes away. I do not have gearscore installed.

Even with this fix, it is hanging up when I open it for inscription. Advanced Tradeskill Window used to behave this way for inscription. It just hangs until disconnect.

Also noticed that all recipes are being listed repeatedly under different category headings, at least in cooking.

I made the changes as shown and GTF seems to be working fine. No slowness and I don't run Playerscore. Now if you techie types could fix my other add-ons LOL.

That's entirely possible. I haven't really looked into PlayerScore, since I can live without it until they update it, unlike GnomeWorks :)

Thanks to athgar for the tip. Easier done than said.

And PlayerScore is definitely causing the slowdown here. Maybe something to do with the removal of some gear slots?

Re: the slowness - are you using PlayerScore/GearScore? I was having the same problem and it ended up having something to do with how PS modifies item tooltips.