!NoTaint

Table of Contents

This project is abandoned and its default file will likely not work with the most recent version of World of Warcraft. Whether this project is out of date or its author has marked it as abandoned, this project is no longer maintained.

Reduce the chance that talent switching be forbidden.

These codes are based on very hard work of reviewing Blizzard's source code and testing taint status. The cause of the failure is rather complicated. As far as we know, there are 3 reasons at least.

1. Addon calls ToggleTalentFrame() to open talent panel.

2. Addon calls StaticPopup_Show()

3. Addon use UIFrameFlash()

4. Addon use ChatFrame_AddMessageEventFilter (related to reason 3.)

This addon can fix reason 1, 2 and 4. But for reason 3, there is no workaround fix, you have to modify the code where UIFrameFlash is called (or contact author to fix it).

Comments

_ForgeUser15976466
- Join Date: 6/20/2014
- Posts: 1
- Member Details
#25 _ForgeUser15976466

View User Profile

Send Message

Posted Jun 20, 2014
1111111111111111111111111111111111111111111111111111111111111

Rollback Post to Revision RollBack
MysticalOS
Community Moderators
- Location: Collins
- Join Date: 1/31/2008
- Posts: 692
- Member Details
#23 MysticalOS

View User Profile

Send Message

Posted Apr 5, 2013
staticpopup still taints, but it no longer blocks glyphs/talents. Although an issue could pop up some where else

Rollback Post to Revision RollBack
mcremor
Curse Premium
- Join Date: 2/10/2007
- Posts: 47
- Member Details
#22 mcremor

View User Profile

Send Message

Posted Mar 19, 2013
How is the situation since the 5.2 patch for WoW? I read somewhere that LibChatAnims is still needed, but what about the other points? Is it still suggested to have this addon installed if LibChatAnims is already provided by some other addon?

Rollback Post to Revision RollBack
Kaustos
- Join Date: 3/12/2009
- Posts: 0
- Member Details
#21 Kaustos

View User Profile

Send Message

Posted Mar 5, 2013
Not only did they NOT fix the bogus taint errors with 5.2, but now this fix doesn't work either. sigh

Rollback Post to Revision RollBack
Fylwind
- Join Date: 12/10/2012
- Posts: 3
- Member Details
#19 Fylwind

View User Profile

Send Message

Posted Feb 16, 2013
@funkydude

I was not advocating removing the LibStub. I stripped it for testing only because LibStub loads after Code.lua so for the sake of simplicity I removed it.

In any case, the problem was my fault. I should've paid more attention to what you said earlier.

Rollback Post to Revision RollBack
Funkeh
- Join Date: 11/20/2005
- Posts: 78
- Member Details
#18 Funkeh

View User Profile

Send Message

Posted Feb 16, 2013
@Fylwind, it would be useful if you answered some of the questions I asked the previous user. The entire point of using LibStub is to prevent re-hooking over and over again. Stripping it is NOT a good thing.

Rollback Post to Revision RollBack
warbabyy
Curse Premium
- Join Date: 5/22/2007
- Posts: 12
- Member Details
#17 warbabyy

View User Profile

Send Message

Posted Feb 16, 2013
@Fylwind

try r14

Rollback Post to Revision RollBack
Fylwind
- Join Date: 12/10/2012
- Posts: 3
- Member Details
#16 Fylwind

View User Profile

Send Message

Posted Feb 14, 2013
So I just updated this addon recently and somehow I feel like I'm getting more taints than I had prior to the update. In particular, the addon will error out and tell me that some add-on has called UIFrameFlash, even though I greped the entire directory and found nothing of the sort. The stack-trace points to Blizzard code as far as I can tell (see below).

The error very reliably occurs when I receive a Battle.net whisper — which I have a second window for, so I suspect that's where the flash occurs. The source of the taint, though, appears to be ChatFrame_MessageEventHandler.

I copied the code from LibChatAnims.lua and pasted directly into Code.lua and surprisingly it works now (after stripping the LibStub boilerplate). So it seems that the hack doesn't work for some reason when embedded as a library, but works fine if placed directly in the code for !NoTaint.

7x !NoTaint-r12\Code.lua:71: AddOn calls UIFrameFlash, you may not be able to switch talent. <in C code> !NoTaint-r12\Code.lua:71: in function <!NoTaint\Code.lua:68> <in C code> FrameXML\FloatingChatFrame.lua:1376: in function <FrameXML\FloatingChatFrame.lua:1368> <in C code> FrameXML\ChatFrame.lua:3298: in function "ChatFrame_MessageEventHandler" FrameXML\ChatFrame.lua:2761: in function <FrameXML\ChatFrame.lua:2754> (tail call): ? <string>:"*:OnEvent":1: in function <string>:"*:OnEvent":1
Rollback Post to Revision RollBack
doctorwizzcurse
- Location: Hershey Highway
- Join Date: 11/20/2005
- Posts: 84
- Member Details
#15 doctorwizzcurse

View User Profile

Send Message

Posted Feb 13, 2013
Getting errors

Message: Interface\AddOns\!NoTaint\Code.lua:71: AddOn calls UIFrameFlash, you may not be able to switch talent. Time: 02/13/13 19:12:57 Count: 31 Stack: [C]: ? [C]: in function `error' Interface\AddOns\!NoTaint\Code.lua:71: in function <Interface\AddOns\!NoTaint\Code.lua:68> [C]: in function `UIFrameFlash' Interface\AddOns\ChatBar\ChatBar.lua:616: in function <Interface\AddOns\ChatBar\ChatBar.lua:602>

Rollback Post to Revision RollBack
warbabyy
Curse Premium
- Join Date: 5/22/2007
- Posts: 12
- Member Details
#20 warbabyy

View User Profile

Send Message

Posted Feb 16, 2013
This is a warning info that ChatBar SHOULD NOT use UIFrameFlash or it will block the talent switching sometimes in 5.1

Rollback Post to Revision RollBack
Funkeh
- Join Date: 11/20/2005
- Posts: 78
- Member Details
#14 Funkeh

View User Profile

Send Message

Posted Feb 10, 2013
@Winney1907
If you're running with disembedded libraries, try r14. If not, for some reason LibChatAnims hasn't loaded for you. Did you update whilst in game? If so, exit wow first.

Rollback Post to Revision RollBack

Winney1907

Join Date: 10/30/2007
Posts: 1
Member Details

#13 Posted Feb 10, 2013

Been getting this error with r13.

Date: 2013-02-10 18:44:16
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\!NoTaint\Code.lua line 71:
   AddOn calls UIFrameFlash, you may not be able to switch talent.
Debug:
   [C]: error()
   !NoTaint\Code.lua:71:
      !NoTaint\Code.lua:68
   [C]: UIFrameFlash()
   ..\FrameXML\FloatingChatFrame.lua:1376: FCF_StartAlertFlash()
   ..\FrameXML\ChatFrame.lua:3298:
      ..\FrameXML\ChatFrame.lua:2949
   (tail call): ?
   (tail call): ?
   ..\FrameXML\ChatFrame.lua:2761:
      ..\FrameXML\ChatFrame.lua:2754
   [C]: pcall()
   Stubby\Stubby.lua:379:
      Stubby\Stubby.lua:325
   (tail call): ?
   [string "*:OnEvent"]:1:
      [string "*:OnEvent"]:1
Locals:
(*temporary) = "AddOn calls UIFrameFlash, you may not be able to switch talent."

Resike
Curse Premium
- Join Date: 10/9/2008
- Posts: 5
- Member Details
#12 Resike

View User Profile

Send Message

Posted Feb 8, 2013
Awesome mod.

Rollback Post to Revision RollBack
MysticalOS
Community Moderators
- Location: Collins
- Join Date: 1/31/2008
- Posts: 692
- Member Details
#11 MysticalOS

View User Profile

Send Message

Posted Jan 30, 2013
i don't doubt. just odd. I have all my guildies run this so we can raid with no taints and not be held up by reloads every boss fight to change talents and glyphs. Works fine

only DC bug people get is the rez bug that knocks you offline from desync for no real good reason that started in 5.1 :\

Rollback Post to Revision RollBack
Sygon_Paul
Community Moderators
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 462
- Member Details
#10 Sygon_Paul

View User Profile

Send Message

Posted Jan 30, 2013
@mysticalos

There was a lot of lagged game textures, lag on zoning or crossing map zones (Towlong Steppes to Dread Waste by flying, for example) followed by "disconnected from server". It didn't seem to matter where I was flying from or to, or where I logged into the game. I could log into Stormwind or Shrine of the Seven Stars or Halfhill; lag, lag, disconnect.

Rollback Post to Revision RollBack
MysticalOS
Community Moderators
- Location: Collins
- Join Date: 1/31/2008
- Posts: 692
- Member Details
#9 MysticalOS

View User Profile

Send Message

Posted Jan 28, 2013
that's weird

it works great fo rme. it really does fix 1 2 and 4, i've tested all cases thoroughly.

Obviously 3 is still very bad, i just avoid or fix mods that call UiFrameFlash() directly or pressure someone else to fix it like kemayo did with silverdragon on Jan 7th. :)

when do you get disconnected? on login, when rezzed? changing zones?

Last edited by MysticalOS: Jan 28, 2013

Rollback Post to Revision RollBack
Sygon_Paul
Community Moderators
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 462
- Member Details
#8 Sygon_Paul

View User Profile

Send Message

Posted Jan 26, 2013
I tried this out because like most people, I keep getting taint errors. Unfortunately, with NoTaint installed, I kept getting disconnected from server.

Rollback Post to Revision RollBack
_ForgeUser711746
- Join Date: 4/14/2008
- Posts: 2
- Member Details
#7 _ForgeUser711746

View User Profile

Send Message

Posted Jan 24, 2013
Work nicely with static popup dialog.

Thanks a lot.

Rollback Post to Revision RollBack
_ForgeUser7804226
- Join Date: 11/3/2011
- Posts: 0
- Member Details
#6 _ForgeUser7804226

View User Profile

Send Message

Posted Jan 23, 2013
Thank you for this. I really hope it will help. This problem doen't happen very often, but when it does its a pain.

Rollback Post to Revision RollBack
MysticalOS
Community Moderators
- Location: Collins
- Join Date: 1/31/2008
- Posts: 692
- Member Details
#5 MysticalOS

View User Profile

Send Message

Posted Jan 22, 2013
i'm one that wrote that test, haha. I wrote it to test 5.2, which actually fixes the taint on blizzards end and compare it to live. Then i tested it with your mod for a bit and found your mod didn't solve my somewhat aggressive tainttest heh.

It's nice you quickly put a fix for it though. that should indeed further reduce taints :) Keep up the good work

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Project ID

50038
Created

Jan 15, 2013
Last Released File

Feb 12, 2013
Total Downloads

47,847
License

GNU Lesser General Public Lice...

13.02.13
Feb 12, 2013
r14
Feb 10, 2013

WowAce

!NoTaint

Addons

!NoTaint

Table of Contents

Comments

About This Project

Categories

Members

Recent Files

WoW Retail