Adibags Legion Filters
Adds AdiBag filters for
- Artifact Power
- Ancient Mana
- Artifact Relics
- Champion Equipment
- Champion Upgrades
- Bait
- Rare Fish
- Legion Reputation items
- Broken Shore items
Adds text to icons for the amount of Artifact Power or Ancient Mana an item gives.
Is an item not in the right section? Have a section you would like to see? Leave a comment below.
Comments
-
legowxelab2z8 Owner
-
Blizzatron Translator
-
View User Profile
-
Send Message
Posted Jan 6, 2017I just updated and started getting some bugs. I'm not at AK25 on this character, so I don't think it's related to that issue? It happens anytime I open my bags when I have AP items in it.
...s\AdiBags_Legion_Filters\Artifact_Power_Currency.lua:55: attempt to index local 'widget' (a nil value)
...s\AdiBags_Legion_Filters\Artifact_Power_Currency.lua:55: in function `AddArtifactPower'
...s\AdiBags_Legion_Filters\Artifact_Power_Currency.lua:92: in function `?'
...ibraries\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...ibraries\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[3]"]:4: in function <[string "safecall Dispatcher[3]"]:4>
[C]: ?
[string "safecall Dispatcher[3]"]:13: in function `?'
...ibraries\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `SendMessage'
Interface\AddOns\AdiBags\core\Bags.lua:90: in function `Open'
Interface\AddOns\AdiBags\core\Bags.lua:119: in function <Interface\AddOns\AdiBags\core\Bags.lua:115>
(tail call): ?
(tail call): ?
Interface\AddOns\AddOnSkins\Skins\AdiBags-v1.9.4.lua:28: in function <Interface\AddOns\AddOnSkins\Skins\AdiBags.lua:27>
nil
-
View User Profile
-
Send Message
Posted Jan 6, 2017Thanks for the bug report. Version 1.4 added displaying the total amount of artifact power you can gain from items in your bag to the currency display at the bottom of the AdiBags frame. The bug here is caused when the Currency Plugin is disable but Adibags Legion Filters tries to add text to the Currency Plugin module anyways. This bug should be fixed in v1.4.1 If you would like to see the new Artifact Power display you will need to enable the AdiBags Currency plugin under Options > Plugins > Currency. If you don't want the new artifact power display then v1.4.1 should function as earlier versions and not give errors.
-
View User Profile
-
Send Message
Posted Jan 6, 2017Thank you very much! That was definitely the problem--I had the Currency plugin disabled.
-
View User Profile
-
Send Message
Posted Jan 4, 2017It seems like the AP display is bugged for knowledge 25. the cause for this seems to be a bug in the wow api(?) and because of that the function in Artifact_Power_Plugin.lua in line 78. if you change the second variable to 26 everything seems to be displayed properly
-
View User Profile
-
Send Message
Posted Jan 5, 2017Thanks for the bug report. The issue is that the game API retruns two different set of values depending on which API call you are using. The game uses 0 based indexes for Artifact Knowledge (C_ArtifactUI.GetArtifactKnowledgeLevel() ). When you don't have any artifact knowledge researched you are considered at level 0. At Artifact Knowledge 25 the game returns a value of 25. Itemstrings used a 1based index. (values returned by :GetItemLink()) That means an artifact power granting item obtained while at Artifact Knowledge 0 has a value of 1. When I was doing the check I was comparing the itemstring value to 25, but since it is offset by 1 it was limiting the display to AK24 values. I removed the maximum AK level since it doesn't need to be there since doing a lookup for a artifact knowledge not in the table will be caught anyways.
TL;DR depending on how you obtain the value Artifact Knowledge starts counting at 0, or counting at 1. The bug was an off by 1 error caused by comparing a value that starts counting at 1 with a value obtained by counting from 0.
-
View User Profile
-
Send Message
Posted Nov 17, 2016Opening bags on my lvl 10 ally warlock :( Beta v1.3.1
18x ...s\Adibags_Legion_Filters\Artifact_Power_Currency.lua:41: attempt to concatenate a nil value
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
[C]: ?
[string "safecall Dispatcher[2]"]:13: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `SendMessage'
AdiBags\core\Bags.lua:131: in function `GetFrame'
AdiBags\core\Bags.lua:83: in function `Open'
AdiBags\core\Bags.lua:209: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[3]"]:4: in function <[string "safecall Dispatcher[3]"]:4>
[C]: ?
[string "safecall Dispatcher[3]"]:13: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `SendMessage'
AdiBags\core\Core.lua:447: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:85>
(tail call): ?
[C]: in function `TurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>
Locals:
nil
-
View User Profile
-
Send Message
Posted Nov 17, 2016Thanks for the bug report. Version 1.3.1 beta added tracking of Artifact Power to the currency display. This bug will be fixed in the next version, but until it gets packaged you can disable the Artifact Power Currency Plugin (Plugins->Artifact Power Currency) since it doesn't add functionality for low level characters that don't have artifact power.
-
View User Profile
-
Send Message
Posted Nov 17, 2016I keep getting the following error whenever I open the mailbox with version 1.3.1:
...s\Adibags_Legion_Filters\Artifact_Power_Currency.lua:41: attempt to concatenate a nil value
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
[C]: ?
[string "safecall Dispatcher[2]"]:13: in function `?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function `SendMessage'
AdiBags\core\Bags.lua:131: in function `GetFrame'
AdiBags\core\Bags.lua:83: in function `Open'
AdiBags\core\Bags.lua:209: in function `?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
[string "safecall Dispatcher[3]"]:4: in function <[string "safecall Dispatcher[3]"]:4>
[C]: ?
[string "safecall Dispatcher[3]"]:13: in function `?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function `SendMessage'
AdiBags\core\Core.lua:447: in function `?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:87>
(tail call): ?
[C]: in function `TurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>
Locals:
nil
-
View User Profile
-
Send Message
Posted Nov 17, 2016Thanks for the bug report. This will be fixed in the next version as soon as I can get it to package. This bug is caused when there are no displayed currencies. You can avoid this bug by: making sure there is a currency displayed (Plugins->Currency) and check at least one that you have; disabling the Artifact Power Currency Plugin (Plugins->Artifact Power Currency); or by downgrading the addon to the last release version.
-
View User Profile
-
Send Message
Posted Nov 15, 2016Hi!
Thank you for this great addon.
I have a feature request: I would like to see the sum of all artifact power items (the amount of artifact power i have im my bags).
Could you perhaps add the artifact power as a currency like gold ?
-
View User Profile
-
Send Message
Posted Nov 16, 2016I added artifact power in bags to the currency display. It is a bit messy right now since the currency display wasn't made in a way to be easily modified. v1.3.1 is tagged as a beta so if you are using the curse client to download addons you will need to right click and change the "Preferred Release Type" to Beta.
Hopefully I can figure out a better way to add to the currency display and add tracking for Blood of Sargeras as well.
-
View User Profile
-
Send Message
Posted Oct 23, 2016Exactly what I was looking for. Have you considered also making an Adibags plugin to handle battle pet things, such as the training stones and pet vanity stuff?
-
View User Profile
-
Send Message
Posted Oct 26, 2016I can make an addon for battlepet items if there is interest. The hardest part is knowing all the items to include. What battlepet vanity items should be included? I would assume battle pet stones, bandages, maybe the consumable one time use pet biscuits, but what else?
-
View User Profile
-
Send Message
Posted Oct 31, 2016Probably all the junk that Mei Francis sells... the leashes, etc, and Pug Costumes?
-
View User Profile
-
Send Message
Posted Oct 1, 2016How can i get Adibag to look like this on the picture? My Adibag is growing to the left and is blocking vendor and auctionwindow....
I want that it grows up not to the left.
Greetings
-
View User Profile
-
Send Message
Posted Oct 2, 2016My AdiBags Settings
Maximum bag height 70% and Compact layout checked. If you have currencies displayed at the bottom of the bag window it can force the bag window to become extra wide so it can display them all. Turning off display for unused currencies can help fix the issue.
-
View User Profile
-
Send Message
Posted Sep 23, 2016Very useful! Thank you.