WowAce

Quote from Kharthus >>

 

 Update: The "Open BankItems bags with Blizzard bags" setting is what will cause the error. It has to be set to see this error message.

 
Thanks to THIS bit of information, I was about to find a fix for this error.

Check it out here:
https://cdn.discordapp.com/attachments/1035400811460706344/1036496585305112657/BankItems.lua

In reply to Centias:

 Thanks!!!!!  That fixed it!

In reply to Centias:

Works great so far!  If this continues to function into DF, would you consider adopting the mod formally or creating a new one based on this?  Xinhuan seems to have been active recently, maybe they'd be willing to hand over the reins if they don't have interest in continuing the project?

In reply to lostdrewid:

 My current intentions are to keep using this addon, so that means I also intend to try to keep it working if I have to. I'm relatively new to programming in lua, so there's a lot of head-scratching, but I usually manage to figure things out.

I see Xinhuan has a lot of other addons he owns or works on. I'm guessing there's just a lot of things vying for his attention. But if there continues to be no official update for this addon, I will probably see about formally adopting it and/or moving it onto github so it's easier for others to get in and suggest modifications/fixes.

In reply to Hawksy2:

 10.0.2 apparently removed "OnTooltipSetItem" for tooltip frames. Figuring out a fix.

Edit: With some work I was able to find some small success, but I haven't been able to figure out the next part:

I added a small go-between function :

function OnTooltipSetItem(self, tooltip, data)
  BankItems_AddTooltipData(self, tooltip, data)
end

I commented out all of function BankItems_Hooktooltip and replaced it with the single line :

TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, OnTooltipSetItem)

Then things sort of don't make sense to me. It shows the line in the tooltip once, for less than a second, then removes it and never shows it again.

At the start of function BankItems_AddTooltipData, if I remove " or self.BankItemsDone " it will work but add the line for where items are 7 times.
I can't seem to figure out how to make it only show once.

Edit 2 : Electric Boogaloo
With a little push in the right direction, I was able to get this working for 10.0.2
https://media.forgecdn.net/attachments/515/538/bankitems.lua

In reply to Centias:

 10.0.2 is out, but even with this patched version that you told us to wait for, is back to generating constant lua errors. lol ;)  Good try tho, hopefully you've already noticed and are taking a look at it. Generated 208x entries in about a 20 second span before I disabled it. :D

208x Interface/AddOns/BankItems/BankItems.lua:6417: bad argument #1 to 'strmatch' (string expected, got nil)
[string "=[C]"]: ?
[string "@Interface/AddOns/BankItems/BankItems.lua"]:6417: in function `BankItems_Generate_SelfItemCache'
[string "@Interface/AddOns/BankItems/BankItems.lua"]:1022: in function <Interface/AddOns/BankItems/BankItems.lua:938>

Locals:
(*temporary) = nil
(*temporary) = "item:(%d+)"
(*temporary) = "string expected, got nil"

In reply to dblanch369:

 This should fix or at least suppress the error, but it also basically goes away once you visit the bank once.
https://media.forgecdn.net/attachments/519/71/bankitems.lua

In reply to Centias:

 This fixed all the errors I was seeing, but now the guild bank isn't  updating anymore.

In reply to turbo_tom64:

 Boom, found a fix, going to bed
https://media.forgecdn.net/attachments/519/130/bankitems.lua

In reply to Centias:

 You're awesome, thanks!!

In reply to Centias:

 I hate to be a pain, but there is one more issue that i just noticed, the reagents in the bank aren't updating.  I appreciate all you've done for this addon.

In reply to turbo_tom64:

 https://www.curseforge.com/wow/addons/bank-items/issues/106
I keep posting more fixes here

In reply to Centias:

 given that Xinhuan isn't inactive per se, just this mod, is it possible you could reach out and be given formal co-ownership of the mod so we can get it properly updated?  I've been using this mod since I've been using mods, period [and I think since before Xinhuan took it over, unless I'm completely misremembering] and I'd hate to see it die.  A fix like yours is great for those of us who check comments and all, but most people are going to see the Last Updated date and pass this over :|

In reply to lostdrewid:

 I did send Xinhuan a message over a week ago, haven't heard anything back. If that continues to be the case, I may have to figure out something I can do that doesn't require their input.

Quote from Kelmor >>

Great addon, please update for DF.

 Yes please!

Message: Interface/AddOns/BankItems/BankItems.lua:1113: attempt to call global 'BankItems_SaveInvItems' (a nil value)
Time: Wed Oct 26 10:03:45 2022
Count: 3559
Stack: Interface/AddOns/BankItems/BankItems.lua:1113: attempt to call global 'BankItems_SaveInvItems' (a nil value)
[string "=[C]"]: in function `BankItems_SaveInvItems'
[string "@Interface/AddOns/BankItems/BankItems.lua"]:1113: in function <Interface/AddOns/BankItems/BankItems.lua:1107>

Locals:

In reply to H8FaTe:

 I think it's safe to assume this addon is forgotten, unfortunately.  Was the best option that I could find for tracking items across multiple toons/factions/realms.

This hasn't been updated in 18 months.

In reply to K4otik:

 Xinhuan has many addons that they author.  I imagine he is prioritizing some over others (He has already updated Handynotes and Gathermate2, etc.).  Just be patient like the rest of us! :)

In reply to dblanch369:

 Really hope he does, as Guild Master and main crafter in guild.. its crucial addon