WowAce

Dinged exalted with Armies of Legionfall and am now getting this lua error:

4x ElkFactions\ElkFactions-1.0.0-29.lua:216: attempt to compare number with nil
ElkFactions\ElkFactions-1.0.0-29.lua:216: in function `UpdateBaseReputations'
ElkFactions\ElkFactions-1.0.0-29.lua:190: in function <ElkFactions\ElkFactions.lua:186>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
Ace3\AceBucket-3.0\AceBucket-3.0-3.lua:116: in function `func'
Ace3\AceTimer-3.0\AceTimer-3.0-17.lua:55: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:48>

A bug i noticed, there is lag when switching between watched factions, even to the point it makes WoW stop responding.

Generally happens when selecting a paragon rep.

Don't know if there will be official updates but I wrote some stuff myself:

Replace line 205:

reputationSessionBase[factionID] = barValue

with:

local paraValue, paraThreshold, paraQuestId, paraRewardPending = C_Reputation.GetFactionParagonInfo(factionID)
			if (C_Reputation.IsFactionParagon(factionID)) then
				reputationSessionBase[factionID] = paraValue
			else
				reputationSessionBase[factionID] = barValue
			end

 In Addition find:

tooltipColors.standingIncrementialOld = FACTION_COLORS_INC_old[standingID] or "|cfff433ff"

 And insert afterwards:

-- new paragon stuff
local isParagon = C_Reputation.IsFactionParagon(factionID)
if isParagon and barMin==42000 and barMax==42000 and barValue==42000 then
	local paraValue, paraThreshold, paraQuestId, paraRewardPending = C_Reputation.GetFactionParagonInfo(factionID)
	repIs = paraValue
	repMax = paraThreshold
	standingText = "Paragon"
	tooltipColors.standingBlizzard = "|cfff433ff"
	repDelta = repIs - reputationSessionBase[factionID]
	if (repDelta < 0 ) then
		repDelta = repDelta + 10000
	end
elseif (not isParagon) and barMin==42000 and barMax==42000 and barValue==42000 then
	repIs = 999
	repMax = 1000
end

 I hope this helps ;)

This will fix:

- old exalted reputation display

- new paragon status on factions

- current paragon reputation

- reputation earned during session for paragon reps

Worked perfectly.  Thanks for sharing!

Sure. You're welcome. Thanks for saying thanks ;)

Quote from Elkano >>

Currently working on my own fixes based on Blizzard's code.

The code you proposed will "break" in some edge cases (new faction reaching exalted and turning paragon, multiple paragon levels in one session, ...?)

But still thanks for trying to drop a quick fix for others :)

 

I'm looking into fixing the general max. standing display (i.e. no more 0/0 or 999/1000) and will try to also fix the two aforementioned cases.

Quote from Elkano >>

Currently working on my own fixes based on Blizzard's code.

The code you proposed will "break" in some edge cases (new faction reaching exalted and turning paragon, multiple paragon levels in one session, ...?)

But still thanks for trying to drop a quick fix for others :)

 

I'm looking into fixing the general max. standing display (i.e. no more 0/0 or 999/1000) and will try to also fix the two aforementioned cases.

The latest update fixed the bug - however, now whenever you gain rep with the faction you have selected to show in the bar, it clears your selection...

Yep, that fixed it :) Thanks!

I came here from Broker_Faction failing to recognize the new "Friend" rep with Conjurer Margoss, and it broke it.  Yours works as well as your buff mod does!  Thank you for the hard coding work.

One thing I did want to mention is that Conjurer Margoss is listed under Steamwheedle Cartel header, under the Classic main header.   If we could get that moved sometime in the future, that would be awesome.  Thank you again for the hard work Elkano.