ElkFactions
ElkFactions is the next step of development for FuBar-FactionsFu. It provides a LDB feed for your currently tracked reputation featuring a tooltip that allows you to view all of your factions.
Comments
-
Elkano Owner
-
View User Profile
-
Send Message
Posted Sep 16, 2016Update fixed the bug. Any chance we can see the auto watch by zone feature implemented as well now?
-
View User Profile
-
Send Message
Posted Sep 17, 2016The auto watch code that was still in there was old code from FactionsFu, that still had some nasty bugs...
But I changed a bunch of stuff and hopefully it's now working as intended.
In order to use it, you'll have to install HereBeDragons-1.0 though, and activate it in the options.
-
View User Profile
-
Send Message
Posted Sep 11, 2016ElkFactions Tooltip dont work anymore after i got reputation for Summoner Margoss (Fishing Man on the isle in front of Dalaran)
Date: 2016-09-11 23:08:46
ID: 2
Error occured in: Global
Count: 12
Message: ..\AddOns\ElkFactions\ElkFactions.lua line 373:
attempt to concatenate local 'name' (a nil value)
Debug:
ElkFactions\ElkFactions.lua:373: UpdateTooltip()
ElkFactions\ElkFactions.lua:91: OnEnter()
Fortress\Core.lua:255:
Fortress\Core.lua:226
Locals:
[...]
-
View User Profile
-
Send Message
Posted Sep 12, 2016Got the same issue. :(
(Still working on my other chars.)
Would be great if someone could fix it.
-
View User Profile
-
Send Message
Posted Sep 12, 2016Was really getting annoyed by this so I went in and made the change. just add
if name ~= nil then
to line 369 and insert after line 381
end
-
View User Profile
-
Send Message
Posted Sep 15, 2016thanks for the temp fix, works for me
-
View User Profile
-
Send Message
Posted Sep 14, 2016Haven't met him, yet. So the error doesn't occur for me.
But judging by the report it seems like GetFactionInfo(...) doesn't return a name for him. Luckily, GetFriendshipReputation(1975) does, and since I call this function anyways, I'll now use its return value for friends' names.
So the latest alpha push should be working; let me know whether it does or not.
-
View User Profile
-
Send Message
Posted Sep 14, 2016Nope the update didnt work :-(
The Guy is on the little flying Isle in front of Dalaran
Date: 2016-09-14 23:31:50
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\ElkFactions\ElkFactions.lua line 374:
attempt to concatenate local 'name' (a nil value)
Debug:
ElkFactions\ElkFactions.lua:374: UpdateTooltip()
ElkFactions\ElkFactions.lua:91: OnEnter()
Fortress\Core.lua:255:
Fortress\Core.lua:226
Locals:
[...]
-
View User Profile
-
Send Message
Posted Sep 14, 2016It looks like the issue is after you meet him an additional faction is added that does not return any values. The bug is with Blizzard since it shows up with no name or rep just above the entry for Summoner Margoss. I was able to get it working by adding a check for nil before setting the tooltip. Additionally I was curious if there was a reason the auto watch by zone code was commented out. I managed to get that working fairly easily while I was looking at the other bug.
-
View User Profile
-
Send Message
Posted Sep 15, 2016Sounds like I'll have some fishing to do in Dalaran Underbelly... :/
-
View User Profile
-
Send Message
Posted Sep 15, 2016I've got it working if you want to take a look at my files. This includes the margoss fix plus the auto watch by zone functionality.
https://www.dropbox.com/sh/sv62av44tklevzq/AACixYMh3XoafS_pkONDXsOTa?dl=0
-
View User Profile
-
Send Message
Posted Sep 3, 2016The call to GetFactionInfo() is currently broken for one unnamed faction and results in nil for the name (and id).
ElkFactions:UpdateTooltip() needs to check against name = nil too.
e.g. "if name then ....end" around lines 335 and 385.
-
View User Profile
-
Send Message
Posted Sep 9, 2014Just installed this. I click on a faction and I see it in the broker display. But when I log out and log back in, or simply reloadui, all I see is the icon. The faction text is gone. If i bring up the tooltip, the faction is still selected. It's just not "remembering" it in the broker display. I have to always reselect my desired faction every time.
-
View User Profile
-
Send Message
Posted Sep 9, 2014Confirmed. Should be fixed in r21.
-
View User Profile
-
Send Message
Posted Jun 7, 2014the tooltip doesn't show up on my main, but works fine on alts
here is the error message
57x ElkFactions\ElkFactions-r19.lua:217: attempt to index local 'color' (a nil value) ElkFactions\ElkFactions-r19.lua:217: in function <ElkFactions\ElkFactions.lua:217> ElkFactions\ElkFactions-r19.lua:366: in function `UpdateTooltip' ElkFactions\ElkFactions-r19.lua:183: in function <ElkFactions\ElkFactions.lua:175> (tail call): ? [C]: ? [string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5> (tail call): ? ...Ons\ElkFactions\libs\AceBucket-3.0\AceBucket-3.0-3.lua:116: in function `func' ...AchScreenshotter2\Libs\AceTimer-3.0\AceTimer-3.0-16.lua:43: in function <...AchScreenshotter2\Libs\AceTimer-3.0\AceTimer-3.0.lua:36>
Locals: nil
-
View User Profile
-
Send Message
Posted Jun 10, 2014I can see what is happening but I've got no idea why it would do that :/
Seems like one of the values returned from the API is out of range (or something overwrote your color table).
r20 should prevent the error. Should you get some pink text in the tooltip, that's the culprit.
-
View User Profile
-
Send Message
Posted Jun 10, 2014thanks for the quick fix!
the pink one is Brawler's Guild, perhaps it happened because get Exalted with Brawler's Guild will be displayed as "the highest level" in stead of Exalted (i am not sure about that " " string in english as i am using the chinese client)
as it is a special one, leaving it in pink is totally fine though :)
-
View User Profile
-
Send Message
Posted Jun 10, 2014from looking at the code, my guess is that they are handled as a friend faction, which will always be colored green in the vanilla client; I do show different colors based on your standing with them though.
And it seems like in this case, the return value is "messed up".
In case you know how to do it, could you get me the 3rd return value of GetFactionInfo() for that faction, as I don't have it maxed.
-
View User Profile
-
Send Message
Posted Apr 1, 2014Question: I went from FuBar-FactionsFu to this addon and i've noticed that i can't link my rep in chat with this one, did i miss something on the development of this one?
-
View User Profile
-
Send Message
Posted Apr 1, 2014seems like I forgot to pass the pattern to replace so it always posted an empty string... should be fixed in r19.