This project is abandoned and its default file will likely not work with the most recent version of World of Warcraft. Whether this project is out of date or its author has marked it as abandoned, this project is no longer maintained.
GnomeWorks TradeSkill Frame -
a complete replacement for the blizzard trade skill frame.
thanks 7rond, i know the code was in there to handle this stuff, but clearly wasn't working properly.
i'll make those changes.
in terms of tickets and such, i think i'm going to enable forums for gw. in the forums, i'll have discussions for issues with different components (inventory, display, execution, etc). because these issues are typically ongoing and symptoms may change, i think it would be better to handle bug reports this way. then tickets could be actual "actionable" items like lua errors.
i'll include instructions for commands to help debug things in stickies related to each component.
I found the solution for the issue Harmankaya mentioned;
First of all, the GetInventoryItemID() function requires a unit argument in addition to the inventory slot number, so line 24 of FrameHooks/Bank.lua should be changed from;
Don't know if anyone has mentioned it before, but GW has some trouble with profession-bags.
i.e. I got 2000 pigment of aids in my bank, I queue up 1000 ink of aids in GW - it tells me to get the pigments from the bank. I open the bank, click on "bank" to pull the pigments, and it fills up all my bags - except my inscription-bag, and then tells me my bags are full.
I agree with bsmorgan... add some debugging options to the addon and then when we find a problem we can just replicate it in debug mode and copy/paste the result into a ticket ;)
With regards to tickets I think your job is to close them when you believe they are fixed or irrelevant. Our job is to open them (or new ones) when we have reason to believe they aren't fixed or are still relevant.
The fact that future changes might break something that you have previously fixed is something we've all signed up for by using a product in the alpha stage. Hopefully, a new ticket will contain new information that will help fix the new bug!
The code in its current state has features that make it very compelling to use. I think that often causes us to forget that it is alpha code and pressure you for more stability.
If you have problems debugging something, just instrument the code and turn it loose on us. There's enough crafters that follow this addon to generate more than enough debugging information. I've got debugging code imbedded in my addons which can be optionally turned on and off with slash commands. I'm not afraid to ask for debug output when someone discovers a bug I can't reproduce.
i hear ya, contrebasse. the problem is that the foundation keeps being reworked in order to facilitate the additional weight of the roof. take the inventory system. it's been stable and unstable depending on which version you use because introducing a new feature necessitates changing some underlying code. i think this particular aspect is what's causing the most trouble for people at the moment.
i suppose i'm a bit guilty of not prioritizing certain aspects, but it's tough to work on the same bit all the time. and honestly, i find it difficult to debug some aspects because as funny as it sounds, i don't do much crafting. lol.
a lot of tickets could probably be closed, but then a lot of closed tickets could probably be re-opened as things ebb and flow.
It seems to me that GW could be a wonderful addon but the fact that it's currently not really usable breaks all it's wonderfulness.
I know you're doing a lot of work on it, for free, but I keep wondering why you regularly introduce new features while the core is still very unstable. I don't care if the scanning is a bit slow, as long as it does its job. I don't care to see which recipes I will be able to craft if I can't craft the ones I already know.
There's 113 tickets opened, 79 of them are bugs (I guess that a lot of them could be closed, though).
I don't mean to discourage you, go on with this soon-to-be-wonderful addon, but please finish the foundations before working on the roof !
(hopefully not a syntax error, this is off the top of my head)
sub in the itemID for whatever item you're checking.
are you getting any alt inventory for any item?
hades, yeah i've gone back and forth over the selectability of a recipe. each cell handles its own clicking, so a left click in one cell might do one thing and in another it might do something else. right now, left click is only used by the recipe column. not sure what else it would do in another column, so maybe i should just have them all select unless i think of something better.
lilsparky, correct me if im wrong here, but i think the number for the craftable-column still look wrong to me with r123:
as you can see the count for twilight jasmine is shown as 0, although i filled my entire bank with them, almost.
same for the inventory numbers for aszhara veil.
Ive removed the savedvar file before upgrading to r123, and relogged and inspected bank&mail&bags on both main&alt a few times now.
Am i wrong or gnomeworks?
I like idea of having shift-click link to chat if the chat box is open and multi-select otherwise... that would be intuitive to me. good thinking.
One thing that's been bugging me lately is having to click in the recipe name column to actually select the recipe.... I should be able to click anywhere on a row to select the row to craft. Just a minor annoyance as I often end up adding more of the previously selected item to the queue and having to clear it and start again.
new rev is up. i found a major error in my inventory recaching mechanism that would account for a lot of problems. hopefully, it's much better now.
i've added overachiever support and an icon to recipes that are on cooldown.
also, if you experience the non-clickable recipe problem, please type:
/framestack
then mouse over the gw frame and report back here what it says. a screenshot would be ideal...
oddible, the blizz ui actually is similary to what i've got going on. there's a recipe list up top and then a recipe detail below. the detail view contains what item is created purely as an icon as well as other information about the recipe (cooldown, tool usage, reagent usage). recipe names are kind of ambigous with the tradeskill system. is it a recipe name or an item name?
i do get that my linking scheme is not the same as people are used to, but it was a calculated risk in order to enable greater functionality. another option i could do would be to add a "link" button to each recipe, but that might be a bit weird looking with a column of icons. perhaps a "link recipe" and "link tradeskill" button in the main gui would let people know how things work.
raistlan, you can link a trade by shift-clicking the trade button.
harmankaya, that's doable. i need to add multiselecting to the queue frame so you can ctrl-click each recipe you wish to delete and then right-click to delete them all (or ctrl-delete).
fred, yunohu, i'll try to get the inventory bugs sorted out next rev.
yoshimo, overachiever is on the list of things to do. i'll see if i can hack something up quickly. i was sort of wanting to implement a generic icon management system to my gui so i could flag items quickly without having a dedicated column, but maybe i should just add overachiever support without this sytem.
Im using r122 and i think the craftable count is still wrong .
The pink number in the inventory column shows that i can craft flasks and a lot of them, but the
craftable column says "0".
http://wow.curseforge.com/addons/overachiever/ shows icons at cooking recipes you still need to craft for achievements, but not in the gw frame, im not sure which of the 2 addons needs to add support for the other here.
I am getting the same issue as yunohu. Something seemed to have forced it to update on its own. Either visiting mailbox or learning a new recipe i think.
With rev 122, I still had to manually get Gnomeworks to scan my bags using the /script bit on the command line. Under plugins, my inventory tracker says everything is toggled for scanning.
Even after I scan my inventory, the results in the GW screen are wrong. I have 47 rough stones in my inventory (properly reflected), but for the "Grinding stones" item, it says that none are craftable, even though I can hit the "create"/"create all" buttons.
Back in the days with good old skillet, I could i.e. populate a queue with glyphs, then - if for some reason I wanted to delete that particular item from the queue, there was this "X" next to the item.
One click with the mouse, and the item was gone. In GW in its current state I have to right click - and then select delete.
I want this function because when I make glyphs, I use KTQ to queue up 20 of all glyphs, but because of the immense bagspace needed - I actually only want to craft the stacks that end up being 10 or higher.
So: KTQ queue 20 glyph - quick run down the newly populated queue, pressing X on all the glyphs that's a stack of 9 or lower, only to end up with a queue with 10+ stacks.
This takes likes 5 minutes alone these days (especially when factoring in the lag that ensues when you delete something from a bigass GW-queue and the addon recalculates the mats needed.
Hope you will consider this, you've come a long way. :)
well, if it came down to it, i suppose i could have shift-click be link when the chat frame bar is open, otherwise it could be a multi-select.
I see, shift-click conflicts with another feature - what you've written above would be more intuitive at least because we've been trained by Bliz that way. Well, my issue was less with the shift click and more with the location of the click. In the Bliz UI, there is a clear separation of what is 'Recipe', which has the cooldowns, requirements, tools, reagents, etc, and what is 'Product' or the end result of production. It was my impression that the lower left window was supposed to be 'Product' but it seems that the whole lower portion of the screen is meant to be a mix of both product and recipe. This could be fine from a UI standpoint but I was looking for a way to support recipe linking what was intuitive enough to not have a billion people adding comments on Curse asking how to link a recipe. In the Bliz UI, you link via the recipe list, not the product info. That is intuitive again only because we've been trained to operate that way. The word 'Recipe' somewhere would be a key indicator to assist the UI design so it wouldn't require reading the instructions or posting in Curse comments. Just some ideas.
lilsparky:
"what happens if you do this: /script print(GnomeWorks:GetFactionInventoryCount(itemID))"
chat prints 772
thanks 7rond, i know the code was in there to handle this stuff, but clearly wasn't working properly.
i'll make those changes.
in terms of tickets and such, i think i'm going to enable forums for gw. in the forums, i'll have discussions for issues with different components (inventory, display, execution, etc). because these issues are typically ongoing and symptoms may change, i think it would be better to handle bug reports this way. then tickets could be actual "actionable" items like lua errors.
i'll include instructions for commands to help debug things in stickies related to each component.
thoughts?
I found the solution for the issue Harmankaya mentioned;
First of all, the GetInventoryItemID() function requires a unit argument in addition to the inventory slot number, so line 24 of FrameHooks/Bank.lua should be changed from;
to;
In addition there is a typo on line 26;
First condition there should read bagType :)
Don't know if anyone has mentioned it before, but GW has some trouble with profession-bags.
i.e. I got 2000 pigment of aids in my bank, I queue up 1000 ink of aids in GW - it tells me to get the pigments from the bank. I open the bank, click on "bank" to pull the pigments, and it fills up all my bags - except my inscription-bag, and then tells me my bags are full.
Pretty counter-intuitive :D
I agree with bsmorgan... add some debugging options to the addon and then when we find a problem we can just replicate it in debug mode and copy/paste the result into a ticket ;)
Lilsparky,
With regards to tickets I think your job is to close them when you believe they are fixed or irrelevant. Our job is to open them (or new ones) when we have reason to believe they aren't fixed or are still relevant.
The fact that future changes might break something that you have previously fixed is something we've all signed up for by using a product in the alpha stage. Hopefully, a new ticket will contain new information that will help fix the new bug!
The code in its current state has features that make it very compelling to use. I think that often causes us to forget that it is alpha code and pressure you for more stability.
If you have problems debugging something, just instrument the code and turn it loose on us. There's enough crafters that follow this addon to generate more than enough debugging information. I've got debugging code imbedded in my addons which can be optionally turned on and off with slash commands. I'm not afraid to ask for debug output when someone discovers a bug I can't reproduce.
Brad
i hear ya, contrebasse. the problem is that the foundation keeps being reworked in order to facilitate the additional weight of the roof. take the inventory system. it's been stable and unstable depending on which version you use because introducing a new feature necessitates changing some underlying code. i think this particular aspect is what's causing the most trouble for people at the moment.
i suppose i'm a bit guilty of not prioritizing certain aspects, but it's tough to work on the same bit all the time. and honestly, i find it difficult to debug some aspects because as funny as it sounds, i don't do much crafting. lol.
a lot of tickets could probably be closed, but then a lot of closed tickets could probably be re-opened as things ebb and flow.
It seems to me that GW could be a wonderful addon but the fact that it's currently not really usable breaks all it's wonderfulness. I know you're doing a lot of work on it, for free, but I keep wondering why you regularly introduce new features while the core is still very unstable. I don't care if the scanning is a bit slow, as long as it does its job. I don't care to see which recipes I will be able to craft if I can't craft the ones I already know. There's 113 tickets opened, 79 of them are bugs (I guess that a lot of them could be closed, though).
I don't mean to discourage you, go on with this soon-to-be-wonderful addon, but please finish the foundations before working on the roof !
it looks like it's not scanning the faction inventory properly.
what happens if you do this:
/script print(GnomeWorks:GetFactionInventoryCount(itemID))
(hopefully not a syntax error, this is off the top of my head)
sub in the itemID for whatever item you're checking.
are you getting any alt inventory for any item?
hades, yeah i've gone back and forth over the selectability of a recipe. each cell handles its own clicking, so a left click in one cell might do one thing and in another it might do something else. right now, left click is only used by the recipe column. not sure what else it would do in another column, so maybe i should just have them all select unless i think of something better.
lilsparky, correct me if im wrong here, but i think the number for the craftable-column still look wrong to me with r123:
as you can see the count for twilight jasmine is shown as 0, although i filled my entire bank with them, almost.
same for the inventory numbers for aszhara veil.
Ive removed the savedvar file before upgrading to r123, and relogged and inspected bank&mail&bags on both main&alt a few times now.
Am i wrong or gnomeworks?
Hey, new rev is great.. thanks.
Suggestions
I like idea of having shift-click link to chat if the chat box is open and multi-select otherwise... that would be intuitive to me. good thinking.
One thing that's been bugging me lately is having to click in the recipe name column to actually select the recipe.... I should be able to click anywhere on a row to select the row to craft. Just a minor annoyance as I often end up adding more of the previously selected item to the queue and having to clear it and start again.
Keep up the great work :)
new rev is up. i found a major error in my inventory recaching mechanism that would account for a lot of problems. hopefully, it's much better now.
i've added overachiever support and an icon to recipes that are on cooldown.
also, if you experience the non-clickable recipe problem, please type: /framestack then mouse over the gw frame and report back here what it says. a screenshot would be ideal...
oddible, the blizz ui actually is similary to what i've got going on. there's a recipe list up top and then a recipe detail below. the detail view contains what item is created purely as an icon as well as other information about the recipe (cooldown, tool usage, reagent usage). recipe names are kind of ambigous with the tradeskill system. is it a recipe name or an item name?
i do get that my linking scheme is not the same as people are used to, but it was a calculated risk in order to enable greater functionality. another option i could do would be to add a "link" button to each recipe, but that might be a bit weird looking with a column of icons. perhaps a "link recipe" and "link tradeskill" button in the main gui would let people know how things work.
raistlan, you can link a trade by shift-clicking the trade button.
harmankaya, that's doable. i need to add multiselecting to the queue frame so you can ctrl-click each recipe you wish to delete and then right-click to delete them all (or ctrl-delete).
fred, yunohu, i'll try to get the inventory bugs sorted out next rev.
yoshimo, overachiever is on the list of things to do. i'll see if i can hack something up quickly. i was sort of wanting to implement a generic icon management system to my gui so i could flag items quickly without having a dedicated column, but maybe i should just add overachiever support without this sytem.
yoshimo: It's GW that needs fixing for Overachiever support. There is an open ticket for overachiever support in GW that I filed several months ago.
Im using r122 and i think the craftable count is still wrong .
The pink number in the inventory column shows that i can craft flasks and a lot of them, but the
craftable column says "0".
http://wow.curseforge.com/addons/overachiever/ shows icons at cooking recipes you still need to craft for achievements, but not in the gw frame, im not sure which of the 2 addons needs to add support for the other here.
I am getting the same issue as yunohu. Something seemed to have forced it to update on its own. Either visiting mailbox or learning a new recipe i think.
With rev 122, I still had to manually get Gnomeworks to scan my bags using the /script bit on the command line. Under plugins, my inventory tracker says everything is toggled for scanning.
Even after I scan my inventory, the results in the GW screen are wrong. I have 47 rough stones in my inventory (properly reflected), but for the "Grinding stones" item, it says that none are craftable, even though I can hit the "create"/"create all" buttons.
Request:
Back in the days with good old skillet, I could i.e. populate a queue with glyphs, then - if for some reason I wanted to delete that particular item from the queue, there was this "X" next to the item.
One click with the mouse, and the item was gone. In GW in its current state I have to right click - and then select delete.
I want this function because when I make glyphs, I use KTQ to queue up 20 of all glyphs, but because of the immense bagspace needed - I actually only want to craft the stacks that end up being 10 or higher.
So: KTQ queue 20 glyph - quick run down the newly populated queue, pressing X on all the glyphs that's a stack of 9 or lower, only to end up with a queue with 10+ stacks.
This takes likes 5 minutes alone these days (especially when factoring in the lag that ensues when you delete something from a bigass GW-queue and the addon recalculates the mats needed.
Hope you will consider this, you've come a long way. :)
Right clicking and selecting Link works for me; this addon is already a power-user tradeskill replacement.
Is there a way to link the entire tradeskill from the addon, or do I have to open my profession tab to do that?
I see, shift-click conflicts with another feature - what you've written above would be more intuitive at least because we've been trained by Bliz that way. Well, my issue was less with the shift click and more with the location of the click. In the Bliz UI, there is a clear separation of what is 'Recipe', which has the cooldowns, requirements, tools, reagents, etc, and what is 'Product' or the end result of production. It was my impression that the lower left window was supposed to be 'Product' but it seems that the whole lower portion of the screen is meant to be a mix of both product and recipe. This could be fine from a UI standpoint but I was looking for a way to support recipe linking what was intuitive enough to not have a billion people adding comments on Curse asking how to link a recipe. In the Bliz UI, you link via the recipe list, not the product info. That is intuitive again only because we've been trained to operate that way. The word 'Recipe' somewhere would be a key indicator to assist the UI design so it wouldn't require reading the instructions or posting in Curse comments. Just some ideas.