GnomeWorks TradeSkill Frame
GnomeWorks TradeSkill Frame -
a complete replacement for the blizzard trade skill frame.
early alpha just to test some things out.
Comments
-
craigcurse Owner
-
_ForgeUser280725 Author
-
_ForgeUser8814248 Author
-
Forge_User_91081625 Author
-
WildCard_25 Author
-
View User Profile
-
Send Message
Posted Dec 12, 2010The invisible frame might be that yes, because when it happens i still get the menu lower/raise frame showing up (but raising or lowering the frame don't seem to fix the problem either).
I'm pretty sure there is at least one or two other addons that cause that behaviour (pretty sure it's PP, will try to confirm it in the next days and let you know) outside of Grid2, but Grid2 is a culprit i'm sure off. :D
Thx for the explanation for the "combat bug", it explains a lot, thx for working on it (not really a problem most of the time, i just know it cause i've been ganked a couple times while checking Tradeskills).
For the "all tradeskills" list, i'm not totally sure, i will have to check, but you might be right it's probably just a display problem, with the skills showing a 450/450 (instead of 525/525) and the progression/skill-up bar (the one on the recipe windows, indicating with color gradient at what point it turns orange/yellow/green/grey) not displaying it correctly while the hoover tooltip seems to work (at least on some items, i've got a few one, like Light elementium chestguard in bs, displaying 1/525/525/525 for orange/yellow/green/grey which seems weird.
-
View User Profile
-
Send Message
Posted Dec 12, 2010hagu, you need to update lsw to the latest alpha. 107 i think.
azroliak, thanks for the compliments. the "all recipes" list should literally be every recipe active in the game (even ones you can't necessarily access or learn). can you tell me which recipes are missing?
the combat problem relates to secure frames. i have a solution in mind that should make it work much better. the problem is that blizzard doesn't let you move/show/hide secure buttons while in combat to avoid people writing mods that think for you by exposing buttons under your cursor that cast the perfect spell for the moment. this limitation extends to frames that have secure buttons as children. i use a secure button for my processing of pseudotrades because that's the only way it works. anyway, like i said, i have a fix in mind...
as for the unclickable problem. i'll try installing grid and see if i can make it fail for me. the transparent window analogy is pretty right on since there's actually a non-visible frame i use for window controls which seems to be getting the mouse input. it seems like the scrolling frames get pushed behind this...
-
View User Profile
-
Send Message
Posted Dec 12, 2010Just open up tailoring and got this. All crafting no longer works so I have to disable it to craft and I miss it.
Thx
Date: 2010-12-12 14:38:29 ID: 2 Error occured in: Global Count: 1 Message: ..\AddOns\GnomeWorks\plugins\lsw.lua line 603: attempt to call field 'AddToItemCache' (a nil value) Debug: (tail call): ? [C]: AddToItemCache() GnomeWorks\plugins\lsw.lua:603: Init() ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2068: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2064 ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2107: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2090 ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2153: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:2150 [C]: ? [C]: UseAction() ..\FrameXML\SecureTemplates.lua:274: handler() ..\FrameXML\SecureTemplates.lua:541: ..\FrameXML\SecureTemplates.lua:489 [C]: ? ..\FrameXML\SecureHandlers.lua:264: ..\FrameXML\SecureHandlers.lua:261 [C]: ? ..\FrameXML\SecureHandlers.lua:294: ..\FrameXML\SecureHandlers.lua:277 (tail call): ? AddOns: Swatter, v5.9.4960 (WhackyWallaby) GnomeWorks, v96
later
Date: 2010-12-12 14:41:53 ID: 4 Error occured in: Global Count: 1 Message: ..\AddOns\GnomeWorks\plugins\lsw.lua line 582: attempt to call field 'AddToItemCache' (a nil value) Debug: (tail call): ? [C]: AddToItemCache() GnomeWorks\plugins\lsw.lua:582: GnomeWorks\plugins\lsw.lua:571 [C]: CastSpellByName() GnomeWorks\TradeButton.lua:60: GnomeWorks\TradeButton.lua:36 AddOns:
-
View User Profile
-
Send Message
Posted Dec 12, 2010Hi LS, first thing first, really nice job on GW, it's impressive the speed at which it grows toward maturity now. ;) (I'm dead hooked into it and wondering how i did before i stumbled upon it :p)
Quick question, you had an entry in the character list on top right for "All Recipes", that includes some recipes of Cata, but not all and i was wondering if it was just a case of "work to do, not there yet, need data/help with it" or if it's just something i did wrong/forgot to do when updating GW the last time (i wiped the saved variables but it doesn't seems to work) ?
On a side note, i encoutered the same problem than Nowd too, if you enter combat with GW open, you can't close it, and it don't heal on his own. And if you try to open it during combat (did it by mistake once or twice) you just get the "title" windows to appear, but not the rest of GW, and you can only make it to work afterward by closing it and reopening it.
Finally, most of the time GW works fine but it seems it conflict with a couple addons, i've identified two that makes it happens more often, Grid2 (still) and Pallypower. My problem is that when it happens i can't interact with the window (namely the recipe list and list of items in the queue), it's like there is a "transparent texture" put upon the windows.
Any idea of how i can identify the problem, and help fixing it (knowing that it might come from something in Grid2/PP or something else) ?
(I'm sure Grid2 is one of the problem, since just GW and Grid2 without another addon the pb still happen, for PP i'm not certain but it's probable too)
-
View User Profile
-
Send Message
Posted Dec 12, 2010grgz, you can tell gw to use a different recipe by right-clicking on it in the queue frame. so if you have an item that needs 10 infinite dust and it lists "disenchant frostweave boots" as the source, you can right-click "disenchant frostweave boots" and you'll get a popup for all possible sources of infinite dust. you can select a different source here and see how it fits into things. i assume you checked the price between buying the dust and buying the items to craft the boots to de to get the dust.
sarah, what ldb module do you use to open your ts frame? that might have an impact. if i can reproduce it then i can try real fixes. otherwise, i'm just kinda stabbing in the dark. i don't think anybody's ever reported that non-scroll frames have died on them. hmm... what about the scroll bar and mouse wheel? do they work at all? also, if this happens, try activating the layout mode and see if you can manipulate those elements. also, try raising/lowering the fame and see if it helps. maybe see if putting a frame over the gw frame is clickable or whether somehow the gw frame is still clickable.
those lsw errors are from me trying to get lsw to use the gw recipe cache instead of caching data itself. it's pretty much the same format of data so it seemed silly to have two copies of it. those errors are a result of lsw not capturing some extra stuff it needs i think. i will probably undo this change for now until i can rework some lsw internals.
you can probably fix it by using the lsw.lua file from r94 or r95.
oh, and the process button not matching the actual skill to process... for some reason the routine that updates the button to show needs to be done isn't firing when it should. it does eventually get fired by a heartbeat event (every few seconds). i'll track that one down. probably a typo or something silly.
-
View User Profile
-
Send Message
Posted Dec 12, 2010One more. I decided to wipe all trade settings. LSW, GW, Auctioneer database, etc. Now I'm having trouble getting LSW to show a value and I get the following:
Date: 2010-12-12 08:02:44 ID: -2 Error occured in: Global Count: 25 Message: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua line 1856: attempt to index local 'iCache' (a nil value) Debug: [C]: ? ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:1856: OnEnter() GnomeWorks\plugins\lsw.lua:175: func() GnomeWorks\ScrollFrame.lua:787: OnEnter() GnomeWorks\ScrollFrame.lua:405: GnomeWorks\ScrollFrame.lua:403-
View User Profile
-
Send Message
Posted Dec 12, 2010Okay, now one more bug I'm noticing in r96. Sometimes the crafting button shows the wrong thing.
There is a bug going on in there somewhere. I think I've seen this a couple other times this morning.
-
View User Profile
-
Send Message
Posted Dec 12, 2010Date: 2010-12-12 07:07:32 ID: 2 Error occured in: Global Count: 1 Message: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua line 1646: Debug:[C]: ? ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:1646: ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:1605 ...ace\AddOns\LilSparkysWorkshop\lilsparkysworkshop.lua:1740: OnEnter() GnomeWorks\plugins\lsw.lua:227: func() GnomeWorks\ScrollFrame.lua:787: OnEnter() GnomeWorks\ScrollFrame.lua:405: GnomeWorks\ScrollFrame.lua:403-
View User Profile
-
Send Message
Posted Dec 12, 2010Hey LS,
I played around with it a bit when it happened to me the other day, so here are the symptoms I saw when I couldn't click the window.
I'm sure it will happen again if I do some crafting so I'll check the draggability if it pops up again.
Also, I have been using a LDB plug-in to launch my trade skills, is there any reason to believe that this would have an effect? I'm pretty sure when I first started seeing this I prevented that particular LDB add-on from loading and still got the same results, so I haven't been too concerned that it might be the culprit.
It also occurs to me that I may not have wiped my saved variables after the last upgrade. Any reason to suspect this would be the culprit? In the past when I've had this problem, I'm pretty sure that resetting them didn't help.
Thanks for looking into this,
Sarah
-
View User Profile
-
Send Message
Posted Dec 12, 2010After my last post GW decided the best way to get _any_ infinite dust was to buy a crapload of frostweave cloth, tailor a bunch of boots/whatever, and disenchant them. I ended up bypassing the shopping list and buying my dust directly... Weird. I guess whatever it was reset itself when I logged off because this evening everything has been working fine - no crazy disenchant shopping, and no unclickable items.
The grayed items on the auction window make perfect sense once I understood that it's tied to the Blizzard auction window paging. It just wasn't obvious what was going on... Puting the auctions in the Blizzard frame makes a lot of sense if you can figure out the appropriate window management. You'll probably want to focus the Blizzard auction frame and GW tab when I click Scan or a shopping list item. Screen real estate management is always a pain...
I can see how it would be tricky to find an optimal set of purchases for the lowest price. I guess the current scheme works fine except when the chosen purchase is 10 times the quantity needed. Easily worked around, but it sometimes makes the cost estimates screwy. "400g??"
-
View User Profile
-
Send Message
Posted Dec 12, 2010Why yes i did have stuff queued. Sorry man. not getting much sleep in the stampede to 85.
-
View User Profile
-
Send Message
Posted Dec 12, 2010frosty, does it only lag in enchanting?
bowlam, those ss's kind of indicate that indeed it's tracking properly (you have 167 blackfallow inks) but isn't displaying that data correctly in the main frame. i think i know why, so this should be an easy fix.
nowd, yeah, gw can't close in combat because it employs secure frames to handle some processing functions. i can probably get around this to some degree, but it's a low priority at the moment.
fred, the inventory column in the main frame is broken in 96, but the craftable count should be okay. did you have anything in your queue that was using those silk?
-
View User Profile
-
Send Message
Posted Dec 11, 2010Did r96 break the craftable/inventory columns?
Spirit mend belt (4 silk, 2 threads). In the main window the craftable/inventory columns are empty (wrong i can make 1). In the reagent window silk says 0/4 (wrong i have 4 in my bags) and thread 2/2 (correct i have 2 in bags).
-
View User Profile
-
Send Message
Posted Dec 11, 2010Not sure if this bug has been reported yet but just wanted to quickly post it before I forget. I couldn't close the GnomeWorks window while in combat. I was checking a recipe when a mob aggro'd me and the window was in the middle of my screen blocking most of my view. Was clicking the X button but it was unresponsive. Was able to click it close when I got out of combat tho.
-
View User Profile
-
Send Message
Posted Dec 11, 2010Lilsparky,
I have two links below. Each is to the same image but with a different version of GW. Each has my guild bank open and my bag open so you can clearly see that there are inks etc in my bag. In r95 it is showing the relevant info in inventory but in r96 is is not.
If you need any more info please let me kn ow. Am happy to try and hgelp.
Well done on addon ... it is really great.
r95
r96
cya
Bill
-
View User Profile
-
Send Message
Posted Dec 11, 2010If I open my enchanting window with gnomeworks loaded I will slowly beginning lagging until the entire game freezes completely.
Even after wiping the savedvariables and disabling all other addons, it is still happening.
Using r96
-
View User Profile
-
Send Message
Posted Dec 11, 2010grgz, i take all comments as constructive, so don't worry about throwing things out there.
it would be interesting to learn that some buttons are clickable while others are not (or even some elements are while others are not). i think it's happened to me one time and it seemed to be that a it affected the entire scroll frame as a whole. but other elements were okay. if you can repeat the problem, see if exactly what responds to mouse clicks and what doesn't. also, try a right click. it appears that it falls thru to the base window (it'll give the raise/lower dropdown). does it also allow you to drag the window around (click and hold) like any other "dead" space on the window? these are all tests i'd do if i could repeat it!
i definitely intend to have gw remember grouping/sorting/filtering for each trade skill. perhaps delineated between yours and others as well. i just don't currently have a mechanism to save those settings yet as i haven't spent too much time considering the structure for my configuration options.
good point about the queue window. i agree that it's a bit of a hassle to open both. maybe i could come up with some sort of "tear off" scheme, or maybe a simpler "unlock" ability so that the queue is more directly attached unless you specifically tell it to behave more like a sibling window rather than a child. and i agree it would be nice to have a button to open the main window again. the problem there is that it's ambiguous which trade skill you would like to open. i suppose it could just do that last one.
for the auction window, i may go ahead and plug that into the blizzard auction frame as a separate tab. the current window is really quite stripped down because i wasn't sure what exactly to do with it. i think putting it in the blizz frame would make the most sense since it's really only accessible at the ah.
the auction scanning system works like this: gw scans the ah for anything it thinks you might need for the items in your current queue. it tallies up the total available items and also records each individual lot for sale, sorting by cheapest per unit price. then it goes over your queue and tries to figure out how to get things crafted using your personal stock of items first and then attempting to either buy or craft anything you don't have. it should use current ah prices for this, but i'm not sure this is working properly. you can swap source around in the queue to compare prices and also look at individual reagents in the auction window to see which might be cheapest. gw does not (currently) split methods for any particular queue entry (meaning it'll try either all of reagent A or all of reagent B and not some of each).
the best way to use it is to queue up your items, then scan the ah so it can figure out what's available and how much it might cost. then you can scan each item to see what's available and buy some of the cheapest stuff. you should probably then rescan so it can refactor the queues with your new purchases to see if you should keep buying the same stuff or switch to something cheaper (this gets around the problem with not splitting up methods). buy until the things are too expensive or you run out of money, then go collect and start crafting.
one thing i need to do is add an indicator of how far in your list you'll be able to craft with your current queue and current inventories. also, i think there needs to be some additional info in the auction frame to indicate just what a good price is (lsw could provide this info) so you can tell if current prices are outrageous without thinking too much or having to mouse over things.
the auction system is limited by the blizzard auction api. namely that each purchase requires a hardware event and also that you can only purchase items based on their index on the current scanned page. the gray items in the list are those that not on the current page so the first click will scan to that page, the second click is then the one used to fire off the purchase event. i'm walking a fine line between "oops i just bought something bad" and "yes i want to buy that! it's why i clicked it". i think some smarts could definitely be introduced to help avoid the wrong thing. for example, if you buy 20 item X's for 10g and there are 20 item X's for 5g, it could show a popup and get a confirmation first. same thing with outrageous prices in general.
the disenchanting system in gw is based purely on the items you can personally craft. this is to avoid having an enormous database of all items. i suppose tho that once the disenchant recipe has been loaded, it might make it into the auction system. that wasn't really intended, tho. it would be nice to have it scan for items to de, but that would need to be done in a more generic way. it would require some kind of "meta item" instead of specific items (ie, "rare ilevel 35-39 weapon" vs "dagger of coolbeans"). it would be awesome to get in there, but that's for later down the road.
the auction preference is definitely tricky. i'm going with the simple per unit price for now because having too many reagents is usually not a bad thing for mass crafters and since you buy the items by hand anyway, you can always check to see if there's a cheaper alternative.
i've recently created a slash command handling system, so eventually you'll be able to hotkey specific frames using macros. right now, the only command is "/gw show" which will open "All Recipes" to whichever tradeskill you ask for (or first aid if you don't specify). eventually, it'll open to any tradeskill for any player. maybe adding the word "queue" would be a way to have it open w/ the queue open or just the queue if you type "/gw show queue".
also, i'd like to get an ldb module to help with some of the window showing stuff.
-
View User Profile
-
Send Message
Posted Dec 11, 2010First, kudos on this great addon! Some comments - hopefully constructive. (Apologies if they've already been covered...)
- I've run into something similar to sarah in the reagents list under the Scan Auction button. If there are a lot of reagents sometimes some auction items aren't selectable. Sometimes I can get it to work by collapsing the mail and/or vendor headings, etc. (But now that I'm typing this I can't reproduce the glitch, meh...)
- GW should remember the grouping mode and sort orders between game sessions.
- When reopening the frame it should remember whether the Queue panel was open (e.g. if I closed both windows by hitting ESC).
- I wish the corner X button closed the Queue panel too, since it's really a child of the main frame. Maybe there could be a separate button on the Queue panel to hide/recall the main frame while leaving the Queue open?
- Seems a bit awkward to have a separate window for the Auctions list. Now there's something else to manage/close. Maybe close it automatically when closing the Queue panel? Also close it when clearing the queue? So it behaves more like a popup...
- I'm not sure what the Scan Auctions button is for? To pre-load results for the current shopping list? Am I always supposed to start with this? Sometimes I can lookup individual items without doing Scan Auctions first, but sometimes things seem to get "stuck" (Auction window shows the wrong items and stops doing individual lookups, or the shopping list is empty when it shouldn't be) until I do Scan Auctions. Not sure how to reproduce this though.
- Not sure why some (or all) items in the Auctions window are sometimes grayed out with "click to search"? Is this a sort of paging scheme to avoid refreshing the whole list? But if the grayed out items are stale should they be shown at all? I'm also a little worried about using the same action (left click) for both searching and buying. Could make an expensive mistake...
- Sometimes a other items (boots, etc) show up in my queue/shopping list. Does it really automatically buy stuff to disenchant if there's not enough dust on the AH? Pretty spiffy! Does it compare prices, or will it always prefer AH reagents to disenchanting stuff? I have to admit I'm a bit wary of letting it make these decisions. :-)
- I notice it's tricky to decide which auctions to prefer. The one with the best price per item but maybe a much larger stack than I need (what it does now), or the combo that satisfies the current shopping list for the cheapest price. The latter probably should be the default, but a choice would be nice. (If you want to get fancy you could have some kind of threshold where it will spend a bit more for a better per-unit price, but not -too- much more. :-) )
- Disabling the LSW plugin via the Plugin button doesn't remove the Value and Cost columns.
- Might be useful to label the shopping list as such. Maybe it's obvious, but with so many lists it might help.
- It would be nice if I could bind a hotkey to show/hide the window.
Sorry for the wall of text - hope that sparks some ideas. Thanks for the work you've done already - it's really useful.
-
View User Profile
-
Send Message
Posted Dec 11, 2010yeoman, i'll take a look at the "create all" logic. some things have bounced around a bit and maybe i broke something related to this.
bowlam, that helps a lot. it sounds like it's not realizing what item is crafted in order to tell you how many you have. click on an item that uses an ink and see if the inventory list has the correct number of inks listed there. if it does, then we can be pretty certain the problem is isolated to the display in the main window and not deeper in the inventory tracking system. i'm unable to go online till later or i'd check myself.
sarah, i've never had that issue occur for me, so it's tough to debug. i'll try hammering on it to see if i can get it to happen.
-
View User Profile
-
Send Message
Posted Dec 11, 2010"Create All" doesn't work, if i have queued glyphs, and that queue don't need any more of Ink of the Sea. Pressing this button just creates one ink, and stops. In screenshot you can see, that i have 88 pigments, and i want to free up bag space, before starting on glyph queue. "Craftable" columns are empty too, but there must be 44 for Ink of the Sea. That issue is up for many versions before, i don't even remember, was it ever working or no.
Another issue is that Quartz addon crashes, when i try "Create All", but i don't care for now much about it, just disabled for that char for now.
http://img64.imageshack.us/img64/817/wowgwcreateallwowscrnsh.jpg