nQuestLog

Table of Contents

Questing minion
---

August 20, 2009: I have started the tear-down/rebuild of this addon and will keep this description updated as I go. My path will be:
1) DONE - Thanks Fyrye. Update the libraries so we can get it working without yelling at you, albeit with a bit of tweaking
2) Update the code to work with the new questlog api
3) Recode and reduction of external library dependancy

Comments

_ForgeUser292779

Join Date: 7/25/2007
Posts: 6
Member Details

#166 Posted Aug 16, 2009

Thanks CB (short for CasualBlair)! :)

Just wondering if you might have an idea. I did the "QuestDifficultyColor->QuestDifficultyColors" and "GetDifficultyColor->GetQuestDifficultyColor" changes and everything works fine, except one error I get. When I click the quest to get the details I get the following error:

Date: 2009-08-16 12:15:18
ID: 1
Error occured in: Global
Count: 1
Message: ...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua line 304:
   'for' limit must be a number
Debug:
   [C]: ?
   ...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua:304:
      ...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua:301
   (tail call): ?
   [C]: QuestLog_Update()
   ..\FrameXML\QuestLogFrame.lua:302:
      ..\FrameXML\QuestLogFrame.lua:293
   [C]: Show()
   ..\FrameXML\UIParent.lua:1570: SetUIPanel()
   ..\FrameXML\UIParent.lua:1392: ShowUIPanel()
   ..\FrameXML\UIParent.lua:1308:
      ..\FrameXML\UIParent.lua:1304
   [C]: SetAttribute()
   ..\FrameXML\UIParent.lua:1934:
      ..\FrameXML\UIParent.lua:1922
   [C]: ShowUIPanel()
   nQuestLog\nQuestLogEvents.lua:387:
      nQuestLog\nQuestLogEvents.lua:377
   [C]: ShowLog()
   nQuestLog\nQuestLogEvents.lua:312: OnQuestLogClickQuest()
   nQuestLog\nQuestLogEvents.lua:162: OnQuestLogClick()
   [string "*:OnMouseDown"]:7:
      [string "*:OnMouseDown"]:1

I don't use the nQuestlog details frames as I preferred "Doublewide" with "LightHeaded" attached. But with Blizz making "DoubleWide" obsolete, I just use the default Blizz questframe now. This error occurs when clicking the quest to get details. It pulls up the correct quest and I don't notice anything wrong. Not a big deal as it only pops once per session due to Swatter. But it would be nice if I could get rid of it completely. Any thoughts?

Gonna keep poking around in the code to see if I can resolve it as the function was copied from questfu, but an answer from someone who knows lua would be helpful.

Cheers and thanks for picking this up.

_ForgeUser1200495
- Join Date: 9/30/2008
- Posts: 3
- Member Details
#164 _ForgeUser1200495

View User Profile

Send Message

Posted Aug 15, 2009
I have picked up this addon. Description has been upgraded with plans, but as I also hold down a job and family I cannot give firm dates.

Sooner than later, and sooner than Blizzard Soon™ if thats any consolation.

Rollback Post to Revision RollBack
_ForgeUser13377
- Join Date: 4/23/2005
- Posts: 11
- Member Details
#160 _ForgeUser13377

View User Profile

Send Message

Posted Aug 11, 2009
StijnH which one would you suggest? I have not found any that are close to nQuestLog and it saddens me to see this one retire.

Rollback Post to Revision RollBack
_ForgeUser1198108
- Join Date: 6/28/2019
- Posts: 0
- Member Details
#159 _ForgeUser1198108

View User Profile

Send Message

Posted Aug 10, 2009
Anyone have any suggestions for an alternative similar mod?

Rollback Post to Revision RollBack
_ForgeUser1193015
- Join Date: 9/30/2008
- Posts: 0
- Member Details
#162 _ForgeUser1193015

View User Profile

Send Message

Posted Aug 12, 2009
I have been using TomQuest2...as it is similar to this mod. I miss this one though do not have time to do the complete rewrite.

Rollback Post to Revision RollBack
LiQiuDGG
- Location:
- Join Date: 2/10/2008
- Posts: 5
- Member Details
#165 LiQiuDGG

View User Profile

Send Message

Posted Aug 16, 2009
i switched to monkey quest...but i really miss nquestlog. :(

Rollback Post to Revision RollBack
fyrye
- Location:
- Join Date: 1/2/2008
- Posts: 20
- Member Details
#158 fyrye

View User Profile

Send Message

Posted Aug 9, 2009
Ok Posted, it's a hack to say the least, but functional. Let me know. In order to compensate for the changes and not doing a complete rewrite, I included librock *cringe*, which enabled it to work. Like I said, its a Hack, but it works. :) Click here to view the packaged files fyrye clone

Last edited by fyrye: Aug 9, 2009

Rollback Post to Revision RollBack
_ForgeUser1139156
- Join Date: 9/20/2008
- Posts: 4
- Member Details
#155 _ForgeUser1139156

View User Profile

Send Message

Posted Aug 8, 2009
Kamarade

Yeah, I second that. Used this mod for ages and it is really good at what it does (or did). Shame to see it die.

Rollback Post to Revision RollBack
Flyinion
- Join Date: 7/29/2006
- Posts: 8
- Member Details
#154 Flyinion

View User Profile

Send Message

Posted Aug 8, 2009
I've applied all the fixes listed here, but just realized the blizzard quest log is no longer showing levels. Anyone have a fix for that? Of course nQuest is showing levels but it's nice to see them in the Blizz log too.

Rollback Post to Revision RollBack
_ForgeUser45812
- Join Date: 10/29/2005
- Posts: 0
- Member Details
#167 _ForgeUser45812

View User Profile

Send Message

Posted Aug 17, 2009
The default log never shows levels, you must have removed the addon you used to use for this.

Rollback Post to Revision RollBack
vsaR1SK
- Location: Stalingrad
- Join Date: 10/24/2007
- Posts: 49
- Member Details
#152 vsaR1SK

View User Profile

Send Message

Posted Aug 7, 2009
Date: 2009-08-07 21:13:56
ID: 103
Error occured in: Global
Count: 1
Message: ...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua line 304:
'for' limit must be a number
Debug:
(tail call): ?
[C]: ?
...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua:304:
...\nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua:301
(tail call): ?
[C]: QuestLog_Update()
..\FrameXML\QuestLogFrame.lua:302:
..\FrameXML\QuestLogFrame.lua:293
[C]: Show()
..\FrameXML\UIParent.lua:1570: SetUIPanel()
..\FrameXML\UIParent.lua:1392: ShowUIPanel()
..\FrameXML\UIParent.lua:1308:
..\FrameXML\UIParent.lua:1304
[C]: SetAttribute()
..\FrameXML\UIParent.lua:1934: ShowUIPanel()
..\FrameXML\UIParent.lua:1918: ToggleFrame()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
AddOns:

Rollback Post to Revision RollBack
_ForgeUser189757
- Join Date: 12/31/2006
- Posts: 5
- Member Details
#147 _ForgeUser189757

View User Profile

Send Message

Posted Aug 6, 2009
Sad news. I hope someone will pick this up. I tried lots of other questframe addon but none is as good as nQuestlog.

Rollback Post to Revision RollBack
Forge_User_56588038
- Join Date: 11/17/2007
- Posts: 10
- Member Details
#146 Forge_User_56588038

View User Profile

Send Message

Posted Aug 6, 2009
Just a quick message for those still using it (I was one of them, up till yesterday).

While I intended to 'fix' the addon, I quickly realised that only a complete rewrite would work.
Updating the outdated libraries would require lots of code changes, and unfortunately I do not have the time to rewrite such a huge addon.
Fixes posted here can work, but as soon as they are added to the SVN, the addon breaks completely cause of the libraries.

Rollback Post to Revision RollBack
_ForgeUser1200495
- Join Date: 9/30/2008
- Posts: 3
- Member Details
#149 _ForgeUser1200495

View User Profile

Send Message

Posted Aug 6, 2009
I'm a professional programmer looking to contribute to the addon community - would you or anyone be offended if I took it upon myself to do the rewrite?

Rollback Post to Revision RollBack
Forge_User_56588038
- Join Date: 11/17/2007
- Posts: 10
- Member Details
#150 Forge_User_56588038

View User Profile

Send Message

Posted Aug 7, 2009
Not at all :)
But be warned though, it's a lot of work :P

Rollback Post to Revision RollBack
_ForgeUser1200495
- Join Date: 9/30/2008
- Posts: 3
- Member Details
#153 _ForgeUser1200495

View User Profile

Send Message

Posted Aug 7, 2009
Thanks for the warning, and the approval. I'll see what I can come up with.

Rollback Post to Revision RollBack
_ForgeUser1247319
- Join Date: 10/9/2008
- Posts: 0
- Member Details
#156 _ForgeUser1247319

View User Profile

Send Message

Posted Aug 9, 2009
You sir, are my hero...

Rollback Post to Revision RollBack
Forge_User_56588038
- Join Date: 11/17/2007
- Posts: 10
- Member Details
#161 Forge_User_56588038

View User Profile

Send Message

Posted Aug 12, 2009
Ownership has been transferred to you :)
Good luck!

Rollback Post to Revision RollBack
Flyinion
- Join Date: 7/29/2006
- Posts: 8
- Member Details
#163 Flyinion

View User Profile

Send Message

Posted Aug 14, 2009
Good luck. Let me know if you can use an assistant. I've been interested for a while in playing with writing addons, but didn't feel comfortable taking this over since I have 0 .lua experience. I might be up for helping out a bit though.

Rollback Post to Revision RollBack
Forge_User_56588038
- Join Date: 11/17/2007
- Posts: 10
- Member Details
#145 Forge_User_56588038

View User Profile

Send Message

Posted Aug 6, 2009
Just a quick message for those still using it (I was one of them, up till yesterday).

While I intended to 'fix' the addon, I quickly realised that only a complete rewrite would work. Updating the outdated libraries would require lots of code changes, and unfortunately I do not have the time to rewrite such a huge addon. Fixes posted here can work, but as soon as they are added to the SVN, the addon breaks completely cause of the libraries.

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.