WowAce

In reply to Greybit:

 in Modules\Quest.lua:

2923: change GetDistanceSqToQuest to C_QuestLog.GetDistanceSqToQuest

5646: same

In reply to pjotrpottervogel:

Still getting the following error when a world quest is being tracked when shift clicking the quest on the map.

Prevents the quest tracker from showing until its removed.

Item button is now working correctly.

19x SorhaQuestLog\Modules\Quests.lua:2496: Usage: GetQuestLogSpecialItemInfo(index)
[string "=[C]"]: in function `GetQuestLogSpecialItemInfo'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2496: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2479: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2631: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2573: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:3500: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:5333: in function `GetQuestLogInformation'
[string "@SorhaQuestLog\Modules\Quests.lua"]:4856: in function `?'
[string "@Ace3\AceTimer-3.0\AceTimer-3.0-17.lua"]:55: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals:
(*temporary) = nil

In reply to Greybit:

  (fixed; download again from same url)

In reply to Greybit:

  (fixed; download again from same url)

In reply to RubioTwitch:

 Thank you very much! I love you forever ^^

In reply to RubioTwitch:

When clicking on a completed quest it throws back this:

SorhaQuestLog\Modules\Quests.lua:5702: attempt to call global 'GetQuestLogIsAutoComplete' (a nil value)

In reply to Greybit:

another one:

look for line 5700

replace:

if ( C_QuestLog.IsComplete(questInstance.ID) and GetQuestLogIsAutoComplete(questInstance.Index) ) then

with:

local info = C_QuestLog.GetInfo(questInstance.Index)

if ( C_QuestLog.IsComplete(questInstance.ID) and info[isAutoComplete] ) then

In reply to pjotrpottervogel:

 Could you roll all your changes into a .zip file and upload them to github or dropbox?

In reply to mothandras:

 sorry, no. posting here is the best i can do. 

In reply to mothandras:

 I'll be updating mine soon with fixes for what's been reported, and a few that haven't

In reply to Greybit:

  (fixed; download again from same url)

In reply to RubioTwitch:

Thank you very much RubioTwitch! I feel lost questing without Sorha.

Really hoping there will be an update for Shadowlands. SQL isn't working at all in 9.0.1

Please forgive me if I'm missing something obvious but I'm having an issue and can't seem to solve it.

Bonus objectives don't seem to be showing up for me. If I go into an area where one exists, it's still auto-accepting and it has a visual like it seems to be going "into the tracker" but I don't see the progress bar or anything like that. I pretty much just have to keep going until I get the "Quest Complete" audible and chat message telling me I'm done. World quests, etc all seem to work fine.

I hadn't gone into the settings for some time but I didn't see anything obvious that may have changed.

I have no idea of maybe WoW made some sort of weird change regarding this functionality and am also admittedly making an assumption that this is due to something in Sorha but I can't figure it out. Any suggestions other than starting with a fresh install? Which I will do but I was hoping to avoid if at all possible....

Thanks in advance!

Sorry! I should have checked the bug reports first. I found this had been noted previously and the fix posted still works (https://www.wowace.com/projects/sorhaquestlog/issues/112).

The "more work?" sound is 558127  (the number listed below is for peonwhat3, not peasantwhat3)

Rhia

Quote from Dzendrieh >>

So.. workaround for me was to reset my profile and set up again. Quests are now tracking fine after about an hour of testing. Hope that helps.

 

Regarding sounds,  I think Blizzard made some changes to the way custom sounds are handled in AddOns for 8.2. I saw a lot of people complaining about various problems with that.

 

Hopefully we'll see an update of this AddOn soon :)

 

-Dz

 Tried this and it work, thanks!

 I figured out how to fix the sounds  , open the lua file go to line 27 and add the sound file id to the line       id numbers can be found on    https://wow.tools/files

the file name to search for is the name before the .ogg   (PeonReady1 for example)

example of old setup

-- Register framd font
LSM:Register("font", "framd", [[Interface\AddOns\SorhaQuestLog\Fonts\framd.ttf]])
LSM:Register("sound", "Peon Ready", [[Sound\Creature\Peon\PeonReady1.ogg]])
LSM:Register("sound", "More work?", [[Sound\Creature\Peasant\PeasantWhat3.ogg]])
LSM:Register("sound", "Work complete!", [[Sound\Creature\Peon\PeonBuildingComplete1.ogg]])
LSM:Register("sound", "Quest Added", [[Sound\Interface\iQuestActivate.ogg]])
LSM:Register("sound", "Quest Completed", [[Sound\Interface\iQuestComplete.ogg]])
LSM:Register("sound", "Quest Failed", [[Sound\Interface\igQuestFailed.ogg]])

fixed setup

-- Register framd font
LSM:Register("font", "framd", [[Interface\AddOns\SorhaQuestLog\Fonts\framd.ttf]])
LSM:Register("sound", "Peon Ready", 558137, [[Sound\Creature\Peon\PeonReady1.ogg]])
LSM:Register("sound", "More work?", 558143, [[Sound\Creature\Peasant\PeasantWhat3.ogg]])
LSM:Register("sound", "Work complete!", 558132, [[Sound\Creature\Peon\PeonBuildingComplete1.ogg]])
LSM:Register("sound", "Quest Added", 567400, [[Sound\Interface\iQuestActivate.ogg]])
LSM:Register("sound", "Quest Completed", 567439, [[Sound\Interface\iQuestComplete.ogg]])
LSM:Register("sound", "Quest Failed", 567459, [[Sound\Interface\igQuestFailed.ogg]])

hope this helps keep this great mod alive

Sweet!  I was just about to try to fix this, but you beat me to it!

Thanks,

Rhia

you are welcome , love this addon , glad i was able to figure it out